rn-emoji-keyboard icon indicating copy to clipboard operation
rn-emoji-keyboard copied to clipboard

fix: no emojies, export delete button

Open hlus opened this issue 8 months ago • 5 comments

Description

Fixes #194 - Empty emojis issue Also exports the delete button component for better reusability

Changes

  • Fixed the issue with empty emojis not displaying correctly
  • Exported the delete button component for external use

Testing

  • [x] test
  • [x] typecheck
  • [x] lint
  • [x] prepack

Breaking Changes

None

Additional Notes

The delete button export allows for better customization when implementing the keyboard

hlus avatar Apr 01 '25 14:04 hlus

I did use this code as a patch in one of my project. My QA team is currently testing it. Will share feedbacks as they come.

cchampou avatar Apr 01 '25 14:04 cchampou

Any news on this? The problem persists.

BR1G00 avatar Aug 02 '25 15:08 BR1G00

I need a review and test this PR to confirm it works in 100% cases. Than who own this can merge 😄

hlus avatar Aug 02 '25 22:08 hlus

Regarding the efficiency of the fix, the exact same modification I included in my codebase using a patch package (replacing the code in the modules) works perfectly fine in production since months (>10k users).

cchampou avatar Aug 14 '25 08:08 cchampou

@jakex7 merge this please

Andrija00 avatar Oct 28 '25 12:10 Andrija00