CrankShaft icon indicating copy to clipboard operation
CrankShaft copied to clipboard

Site wide includes/requires

Open TheWebTech opened this issue 5 years ago • 3 comments

Something I personally do is create a custom module, that acts to store all of my site-wide requires. Things like fonts, stuff I know will be needed for every template.

The reason for this is because if you need to change it site wide, it's easier to do it in 1 module that's used everywhere.

The alternative is HubSpot's domain based settings, but for anyone who's been around long enough to do a redesign - basically setting anything there that isn't invisible(like a tracking code) is a huge slap in the face to whomever does a redesign down the road.

If it's possible though doing an include of an html partial file in the

is probably better. modules add html markup even if they have nothing to display.

TheWebTech avatar May 11 '19 14:05 TheWebTech

We do the html partials when we do this. image

ajlaporte avatar May 14 '19 14:05 ajlaporte

Okay so you go the html partial route. Do you load them in the

in drag n drop templates?

TheWebTech avatar May 14 '19 14:05 TheWebTech

I've implemented this concept in 12a6e0c04b35e6128395bab510868cfae7033caf https://github.com/TheWebTech/CrankShaft/blob/f45961200a7bf45059a9935871b3fc2df95c8252/CrankShaft/globals/theme-head.html#L1-L17 This is only doing the header however.

I am not opposed to doing it for the footer too, what's the reason you have a footer_scripts_partial? Only reason I can think of is so you could take advantage of the SRI hash security stuff

TheWebTech avatar May 23 '19 16:05 TheWebTech