CrankShaft icon indicating copy to clipboard operation
CrankShaft copied to clipboard

Do we need recommended.css anymore

Open TheWebTech opened this issue 5 years ago • 6 comments

Any reason to keep recommended.css still? https://github.com/TheWebTech/CrankShaft/blob/245d6ea96bb6f566ffcb90224db0e7e30b8b49d3/theme/cs-grid.css#L14-L17

TheWebTech avatar May 06 '19 22:05 TheWebTech

I rip out things i am going to use and integrate it into my sass files. The rest gets file 13'd

adesignl avatar May 09 '19 15:05 adesignl

I think we'll need to get link directly to the recommended.css to see what alls in it.

If it's fallbacks for anything under IE11 it shouldn't be included.

If it is for IE 11 and up, it should be included but we can have a boolean to disable in theme-settings.css

TheWebTech avatar May 09 '19 15:05 TheWebTech

This is everything in the recommended.css

/* HTML 5 Reset */

article, aside, details, figcaption, figure, footer, header, hgroup, nav, section {
    display: block;
}

audio, canvas, video {
    display: inline-block;
    *display: inline;
    *zoom: 1;
}

audio:not([controls]) {
    display: none;
}

/* Support migrations from wordpress */

.wp-float-left {
    float: left;
    margin: 0 20px 20px 0;
}

.wp-float-right {
    float: right;
    margin: 0 0 20px 20px;
}

/* Responsive Google Maps */

#map_canvas img, .google-maps img {
    max-width: none;
}

/* line height fix for reCaptcha theme */
#recaptcha_table td {line-height: 0;}
.recaptchatable #recaptcha_response_field {min-height: 0;line-height: 12px;}

TheWebTech avatar Jun 07 '19 13:06 TheWebTech

I would say that it is good to keep the items but having a seperate file isnt necessary..

adesignl avatar Jun 11 '19 12:06 adesignl

Sorry slipped.

adesignl avatar Jun 11 '19 12:06 adesignl

lol.

Anyhow so the thought is move all of those styles into the framework, and stop referencing recommended.css?

TheWebTech avatar Jun 11 '19 13:06 TheWebTech