wallpanel-android icon indicating copy to clipboard operation
wallpanel-android copied to clipboard

Fix CPU being turned off.

Open FredericMa opened this issue 3 years ago • 6 comments

This PR should fix the issue seen in #39. The wakelock was only kept for 3 seconds so when the screen was turned off, the CPU was also turned off. In order to fix this, a few things needed to happen:

  • Fix wakelock to prevent CPU being turned off.
  • Add additional wakelock to handle screen state.
  • Add additional broadcastreceiver to handle screen commands separately.

Please review these changes and test them yourself since I'm not an Android dev so maybe things should be done differently. This PR might also impact battery life since the CPU will never be turned off while WallPanel is running.

Maybe you can create a Pre-release for this one so other people can also test it first?

FredericMa avatar Nov 06 '22 20:11 FredericMa

Deploy Preview for wallpanel canceled.

Name Link
Latest commit e47ab5dccf0b65bc071860125723067a4fac6138
Latest deploy log https://app.netlify.com/sites/wallpanel/deploys/636819e3c9d1ab000a4b0269

netlify[bot] avatar Nov 06 '22 20:11 netlify[bot]

@TheTimeWalker Any chance you can find some time to review the changes in this PR?

FredericMa avatar Nov 14 '22 10:11 FredericMa

It looks like this functionality breaks when brightness control permissions are granted. I'll check why this happens.

FredericMa avatar Nov 30 '22 20:11 FredericMa

@TheTimeWalker Would be great to have it reviewed and merged!

amasolov avatar Dec 30 '22 03:12 amasolov

@amasolov It is still regarded as Draft so I've been holding off of reviewing

TheTimeWalker avatar Dec 30 '22 20:12 TheTimeWalker

I'll try to find some time in the coming days or weeks to take a look at the remaining issues with this PR.

FredericMa avatar Dec 30 '22 21:12 FredericMa