TheThingsNetwork
Avoid consecutive disconnect/reconnect messages in the Live Data view
Summary
The live data view currently shows many consecutive connect and reconnect events when the internet connection is lost. This is frequently the case when e.g. closing the laptop or leaving the browser tab unfocused for a long time. We should combine such messages so that only two are shown.
Steps to Reproduce
- Go to live data view
- Either leave the browser tab unfocused for a long while or (easier) disconnect from Wi-Fi or internet a couple of times
- See many synthetic events being generated about that consecutively for each disconnect event
What do you see now?
Many disconnect/reconnect errors being generated consecutively.
What do you want to see instead?
Such consecutive events to be combined into just two events:
- The first disconnect event of the consecutive group
- The last reconnect event of the consecutive group
This also means that such events should not be combined if there was an actual stream event in between them.
How do you propose to implement this?
It's probably best to solve this at the event reducer level, by changing the reducer to only add the synthetic reconnect/disconnect event if there haven't been the same events immediately preceding. In that case, we can simply remove the last reconnect event and replace it with the more recent one.
How do you propose to test this?
Manual testing will suffice for now.
Can you do this yourself and submit a Pull Request?
This is a good first issue.
