arduino-device-lib icon indicating copy to clipboard operation
arduino-device-lib copied to clipboard

Dangling pointer in TheThingsMessage

Open paulbendixen opened this issue 5 years ago • 1 comments

When calling TheThingsMessage::encodeDeviceData, the buffer pointer pointer gets set to a temporary array on the stack, this might happen to work in most cases, but if anything is called between encoding and sending, this might break horribly and is at least undefined behaviour.

paulbendixen avatar Jun 25 '19 20:06 paulbendixen

Thanks for pointing out. Can you file a PR?

johanstokking avatar Jun 26 '19 08:06 johanstokking