arduino-device-lib icon indicating copy to clipboard operation
arduino-device-lib copied to clipboard

Published 20 hours ago • verified publisher icon TheThingsNetwork

Autobaud, sleep, wake changes

Open jpmeijers opened this issue 6 years ago • 8 comments

Let's discuss this first before merging.

jpmeijers avatar Apr 04 '18 20:04 jpmeijers

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 04 '18 20:04 CLAassistant

Thanks for splitting @jpmeijers , looks good to me

hallard avatar Apr 04 '18 20:04 hallard

@hallard can you address @jpmeijers review comments?

johanstokking avatar May 03 '18 08:05 johanstokking

Hmm, you're approving but I don't see @jpmeijers suggestions implemented.

johanstokking avatar May 23 '18 14:05 johanstokking

Well, I'm not an expert of git, @jpmeijers splitted my PR into smaller one and created this one, I thought he was asking for validation, not for implementation. And I'm not sure how to do file changes on a PR from another user.

hallard avatar May 23 '18 14:05 hallard

Yes, I'll make the improvements and come back for feedback. Won't happen that fast though. Perhaps the weekend.

jpmeijers avatar May 24 '18 18:05 jpmeijers

@cimm you may want to assist @jpmeijers if wanted!

johanstokking avatar Jul 19 '18 19:07 johanstokking

@johanstokking Happy to help but... I am a software developer, not (yet) a hardware guy. I can see SerialType &modemStream doesn't make sense but I have no idea why we go for a SerialType over a Stream. Simple renaming I can do. :smiley:

Happy to do the work if someone can give me some simple beginner tasks.

cimm avatar Jul 20 '18 13:07 cimm