Delayed kill of vehicle after napalm mig attack

[Madrageeeeee]

Sometimes units remain alive after a napalm mig attack but then 2 seconds later they miraculously die anyway due to some sort of afterburning effect.

Unsure whether this is intented. Looks like weird game behavior though due to the delay and because no visual damage is being delivered anymore to the vehicle.

You often see this with either techs or vees.

Not 100% sure but think this can also happen with flamer attacks.

[Jundiyy]

This is the burn effect on units, they burn for n seconds.

Behavior = FlammableUpdate ModuleTag_09
AflameDuration = 5000         ; If I catch fire, I'll burn for this long...
AflameDamageAmount = 3       ; taking this much damage...
AflameDamageDelay = 500       ; this often.
End```

[commy2]

Is there no visual effect for this? I know there're hooks that we could add additonal effects, but I always figured there already were visuals.

[Madrageeeeee]

Perhaps my visual settings were / are too low but to me it always seems as if they randomly died.

Verstuurd vanaf mijn iPhone

Op 5 okt. 2021 om 16:20 heeft commy2 @.***> het volgende geschreven:

 Is there no visual effect for this? I know there're hooks that we could add additonal effects, but I always figured there already were visuals.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[xezon]

If I recall correctly there are small fire effects on burning vehicles. Can be tested easily by shooting onto car with Mig Fighter.

[Stubbjax]

https://user-images.githubusercontent.com/11547761/136356332-53a2ab03-ac21-4d00-89b3-5236dce0a4df.mp4

[xezon]

Could you try the same on GLA Quad Cannon?

[Stubbjax]

Could you try the same on GLA Quad Cannon?

No fire effects there either.

[xezon]

I suspect it is possible to add fire effects. But is it cheap?

[Madrageeeeee]

Ahh so ragey not so crazy after all 😁 some small flames would already help people understand the prolonged effect of burning. And would look sickk (hopefully)

guess similar to the nuclear powerplant that slowly dies if it is turned on self-destruction mode. But then with flames?

[commy2]

Testing possible visuals:

https://user-images.githubusercontent.com/6576312/136550275-0b7cbce5-a651-4bbc-ab47-f30f12b37a9b.mp4

https://user-images.githubusercontent.com/6576312/136550286-9beefb13-ae32-4acc-bda1-cb6864d39e06.mp4

[commy2]

https://user-images.githubusercontent.com/6576312/136554652-8039783f-5491-4ec3-be72-6baa7822fa5f.mp4

[Madrageeeeee]

Kinda like the 2nd one and the smokey one. Would try and not make it too big of a visial though. Keeping it rather subtle.

Great work though, i like it!

Verstuurd vanaf mijn iPhone

Op 8 okt. 2021 om 14:12 heeft commy2 @.***> het volgende geschreven:

 https://user-images.githubusercontent.com/6576312/136554652-8039783f-5491-4ec3-be72-6baa7822fa5f.mp4

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[MTKing4]

group of aflame quads performance test

https://user-images.githubusercontent.com/83613147/136849535-37d9de2b-587c-4ee3-a11e-b50f84c96ec5.mp4

[xezon]

Perhaps instead of multiple fire effects we could just add one big dark smoke at the center or engine of the vehicle. It may be lighter on the particle count and better for performance.

[commy2]

https://github.com/TheSuperHackers/GeneralsGamePatch/assets/6576312/9ce6b97d-097e-4547-8fa6-26dfc9c00082

https://github.com/TheSuperHackers/GeneralsGamePatch/assets/6576312/7200faab-a92e-4b50-a358-740e6b445f68

[xezon]

The fire on the infantry is a bit intense. Perhaps some small dark smoke would be better for those.

[commy2]

Infantry is not flammable. They won't need effects. They stop taking damage when leaving the area of effect of a flame weapon immediately.