TheSuperHackers
Identify and label all applied and pending changes that change game state
Identify and label all applied and pending changes that change game state. We did not yet made any changes to SCB files so this should exclusively concern INI files.
This effort helps Community Patch of Community Outpost to figure out build a version that is 1.04 compatible.
This effort was started yesterday. We got to page 24 of the pull request section and added game state mismatch labels. WazzaP + Zsupatchi (or written something like that) have signalled that they can review the rest without me. @tintinhamans Please empower them to add and remove issue labels in this repository.
When the labelling is done, the labels also need to be appended to our yaml files in folder https://github.com/TheSuperHackers/GeneralsGamePatch/tree/main/Patch104pZH/Design/Changes/v1.0 . (These files are used to assemble change logs, based on filters.) The labels in yaml are lower case and sorted alphabetically (like in github). You will then be able to create a pull request for these and we can merge them into main line.
We did notice that the early changes from alanback116 (hanfield) are a mixed bag where multiple independent things may have been touched in one pull. The yaml files should already be split for these, but you need to review into which yaml's the new labels belong exactly. For yaml's from other authors there should be no such confusions.
I will append my other notes from the review later (please remind me if I forget).
I have renamed labels. They are now called:
GameMismatchWith104 GameMismatchWith104Maybe BalanceMismatchWith104
Here are my notes from the session. The labels need to be added to the relevant yaml files. And there were some strange pulls that perhaps need another look.
There is a lot of history dirt at the <100 commit range and it is a bit sad. Perhaps we can at least add some labels to the old pull requests.
The pulls from alanblack166 need some notes that they do shady things. There is a change that adds a ton of INI files beside editing some other INI's. We were not particularly diligent in the first few days, which shows.
Notes
~~### Controversial label added~~
~~Label needs to be added to relevant yaml file~~ ~~* #145~~
~~### Bug label added~~
~~Label needs to be added to relevant yaml file~~ ~~* #274~~
Minor label added
Label needs to be added to relevant yaml file ~~* #330~~
- #562
- #795
~~### Audio, Minor label added~~
~~Label needs to be added to relevant yaml file~~ ~~* #555~~
~~### Audio label added~~
~~Label needs to be added to relevant yaml file~~ ~~* #883~~
Contains multiple changes
- #160
~~### Contains wrong comment in INI~~
~~* #173~~
Reverted change
- #627
Another reverted change
Reference https://github.com/TheSuperHackers/GeneralsGamePatch/pull/679 for all changes that have themselves obsoleted by this one add reverted label
Check what is going on here
- #357
- #636
~~### Add a description~~
~~* #680~~
Zatsupachi and I will take care of handling the INI compatibility issue.
I'll also have to take a look at the YAML file structure, as I don't know how to properly edit it and add in stuff.
Zatsupachi and I will organize to do another session sometime soon, it's just timezones that's the problem.
I'm GMT+8 if that helps in scheduling. I should be good for most days in the week but not Fridays to Sundays since these are my busiest times.
Notes from INI compatibility check session
BalanceMismatchWith104 label added
Label needs to be added to relevant YAML file ~~* https://github.com/TheSuperHackers/GeneralsGamePatch/pull/1716~~ ~~* https://github.com/TheSuperHackers/GeneralsGamePatch/pull/1802~~ ~~* https://github.com/TheSuperHackers/GeneralsGamePatch/pull/1801~~ ~~* https://github.com/TheSuperHackers/GeneralsGamePatch/pull/1787~~ ~~* https://github.com/TheSuperHackers/GeneralsGamePatch/pull/1774~~ ~~* https://github.com/TheSuperHackers/GeneralsGamePatch/pull/1816~~ ~~* https://github.com/TheSuperHackers/GeneralsGamePatch/pull/1939~~ ~~* https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2001~~ ~~* https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2000~~
- https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2087 ~~* https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2086~~ ~~* https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2269~~ ~~* https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2264~~ ~~* https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2262~~ ~~* https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2260~~ ~~* https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2258~~
~~### Buff label added~~ ~~Label needs to be added to relevant YAML file~~ ~~* https://github.com/TheSuperHackers/GeneralsGamePatch/pull/1764~~
~~### Bug label added~~ ~~Label needs to be added to relevant YAML file~~ ~~* https://github.com/TheSuperHackers/GeneralsGamePatch/pull/1893~~
Reverted label added
Label needs to be added to relevant YAML file
- https://github.com/TheSuperHackers/GeneralsGamePatch/pull/1997
- https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2422
~~### Audio label added~~ ~~Label needs to be added to relevant YAML file~~ ~~Label needs to be added to relevant YAML file~~ ~~* https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2188~~
- I strikethrough above what I already added in #2646 .
- Fix: Aurora And Carpet Bomb Model Is Extremely Low Poly #330
Need new yaml file and add Art?
Need new yaml file?
Contains multiple changes
What to do? we have 160_pilot_advanced_training.yaml, 160_pilot_chemical_suit.yaml, 160_pilot_speed.yaml
Reverted change
I tried to do a manual revert but it seems like there are a lot of balance changes that were made again afterwards, and I have no idea what to prioritize.
Check what is going on here
Added ChatGPT description
Reverted label added
Label needs to be added to relevant YAML file
What to do with this?
Identify and label all applied and pending changes that change game state. We did not yet made any changes to SCB files so this should exclusively concern INI files.
This effort helps Community Patch of Community Outpost to figure out build a version that is 1.04 compatible. Uploadevicessesepred
