GeneralsGamePatch Polish localization fixes and improvements

Polish localization fixes and improvements

Authored by dmgreeny

Nov 06 '24 16:11 xezon

Hi! I'm actually a native Polish speaker, so I can review this.

Very nice. Thank you a lot.

Could you perhaps also check these 2 changes:

#2148
#2265
#2266

I am not sure if I did this right. Maybe or probably has mistakes. They are already merged into main, but we can revisit them if you find fault with them.

Mar 02 '25 18:03 xezon

#2148 Everything seems to be fine with the tooltips.

#2265 Helisa seems like a good name (kinda forgot they named it Spirala, it sounds dumb ngl). There are changes in this pull request (i mean the one we're talking in) that change "Helisi" to "Helisy". For some reason I said to keep "Helisi", but after reviewing my review now, "Helisy" is a better name. Thus I fixed my pull request comments regarding Helisi/Helisy change.

#2266 I think the better name is "Walizka z atomówką". Literally translating it is "Suitcase with a nuke". Sounds kinda weird but it's grammatically correct in Polish.

Mar 02 '25 19:03 CrabHead

@dmgreeny You can include that "Walizka z atomówką" fix in this change too.

Mar 02 '25 22:03 xezon

All comments fixed. @xezon your request added @CrabHead Thank you for checking. Please make another pass on new changes. Also please check polish lines here - https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2535 https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2571

Mar 04 '25 09:03 dmgreeny

All done, thank you

Mar 04 '25 10:03 dmgreeny

Helisa seems like a good name (kinda forgot they named it Spirala, it sounds dumb ngl). There are changes in this pull request (i mean the one we're talking in) that change "Helisi" to "Helisy". For some reason I said to keep "Helisi", but after reviewing my review now, "Helisy" is a better name. Thus I fixed my pull request comments regarding Helisi/Helisy change.

Btw I think you did not submit your review, so we cannot see it. Not sure if it makes a difference.

Mar 04 '25 11:03 xezon

Helisa seems like a good name (kinda forgot they named it Spirala, it sounds dumb ngl). There are changes in this pull request (i mean the one we're talking in) that change "Helisi" to "Helisy". For some reason I said to keep "Helisi", but after reviewing my review now, "Helisy" is a better name. Thus I fixed my pull request comments regarding Helisi/Helisy change.

Btw I think you did not submit your review, so we cannot see it. Not sure if it makes a difference.

Oh thanks for the heads up.

Mar 04 '25 11:03 CrabHead

Also please check polish lines here - #2535 #2571

I'll review those later

Mar 04 '25 11:03 CrabHead

I made a change to all Helis instances. Please check if they are correct

Mar 04 '25 12:03 dmgreeny

Thank you

Mar 04 '25 13:03 dmgreeny

Also please check polish lines here - #2535 #2571

I'll review those later

Took look at #2571 , it's all okay.

Going to check #2535 later.

Mar 04 '25 14:03 CrabHead

All fixed

Mar 05 '25 12:03 dmgreeny

checked #2535

Mar 05 '25 23:03 CrabHead

Almost all the recent pull requests are correct for the polish text (#2578 #2660 #2674 #2677 #2678 #2679 #2696 #2697 #2699 #2700 #2701 #2702 )

Only #2675 requires some changes, but other than that very good.

Mar 21 '25 10:03 CrabHead

There are still some unsolved issues like changing from "Imperator" to "Cesarz".

Also why was every mention of "Gatling" changed to "Gattling"???

Mar 25 '25 15:03 CrabHead

Cesarz were fixed, please check

Please highlight other issues that weren't addressed

Gatling change now has its own pull request for all languages - https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2726

Mar 25 '25 18:03 dmgreeny