Fix: China TNT Bombs now hit structures with their primary damage reliably

[xezon]

• Fixes #2373

With this change the primary damage of the China TNT Bomb can now hit structures reliably. Before they would hit with their secondary damage most of the time, because the TNT Bombs would be located too far away from the target structure.

Placing the TNT Bomb on an approaching vehicle still works before the instigator is crushed. Damage on vehicles is unchanged, because the TNT Bomb is placed at the center of the vehicle, meaning it will apply primary damage always.

The reduced ability range requires Tank Hunters to walk closer to their target before the TNT bomb is placed. The increased primary damage radius gives the TNT bomb more reach.

Damages

The damage surplus of a correctly placed TNT Bomb is significant. Buildings will now suffer +233% explosion damage from a single TNT Bomb.

Weapon TNTDetonationWeapon ;Created by tankhunters
  PrimaryDamage = 500.0
  PrimaryDamageRadius = 15.0
  SecondaryDamage = 150.0
  SecondaryDamageRadius = 50.0
...
End

Original

https://github.com/TheSuperHackers/GeneralsGamePatch/assets/4720891/e295d28f-18ce-407d-9475-dd272375b67e

Patched

https://github.com/TheSuperHackers/GeneralsGamePatch/assets/4720891/1a4271a7-2f32-4e51-8dbc-bf82a5f9fc9b

[xezon]

This is a massive buff for all China.

[penfriendz]

This is one of those buff not really buff kinda things. For people who knew how to take advantage of this, this is a massive convenience and increase in consistency. For people that don't, they can now do what only people with insider knowledge could do, and for these people the impact is greatest.

In any case, let's get a table of bombs to kill for each building and pick a damage value which is sensible.

[xezon]

I have now also increased the PrimaryDamageRadius from 10 to 15, which helps to apply primary damage in some edge cases.

[MTKing4]

Placing the TNT Bomb on an approaching vehicle still works before the instigator is crushed. Damage on vehicles is unchanged, because the TNT Bomb is placed at the center of the vehicle, meaning it will apply primary damage always

I Assume this is not tested thoroughly, it needs to

Besides the big damage buff to buildings, i predict it to buff vs clumped units as well, since now the range is higher, you might kill 2 or 3 units with one TNT

[xezon]

I Assume this is not tested thoroughly, it needs to

I think I tested it against AI, which always goes for crush against infantry and it worked. But we can retest.

Besides the big damage buff to buildings, i predict it to buff vs clumped units as well, since now the range is higher, you might kill 2 or 3 units with one TNT

I think I tested this too and natural distance between vehicles is wider. But we can restest. It would be useful to find out what the regular min distance between vehicles is (there is one to avoid collision).