GeneralsGamePatch Change: Add initial delay to Suicide ability

close https://github.com/TheSuperHackers/GeneralsGamePatch/issues/1184

This adds a configurable delay to the Suicide ability from Demogen.

https://github.com/TheSuperHackers/GeneralsGamePatch/assets/6576312/1eb1d336-8de9-4b42-9528-09c398e516a9

The goal is to nerf Demo Rebel Ambush vs armies.

Aug 27 '23 16:08 commy2

The delay is currently set to 3 seconds.

I tested it with all Demogen units and it works. Second test. I tried putting units in some situations where Suicide fails in 1.04 / is buggy, such as while firing (Technical) or while stuck inside buildings (Rebel). All those issues had been fixed previously. With this change, they do not re-appear. Units behave responsive and suicide when ordered immediately.

This change also has extra logic for the Toxin Tractor that frees up the TERTIARY weapon slot, while keeping the ability to suicide. This freed slot can be used for https://github.com/TheSuperHackers/GeneralsGamePatch/pull/1113.

Aug 27 '23 19:08 commy2

Documentation added. I tested Rebel Ambush specifically, and Rebels now need to wait 3 seconds to be able to explode.

Aug 28 '23 14:08 commy2

I tested and it appears to not work on vehicles.

Which vehicle? Which map?

shot_20230828_172939_2 shot_20230828_172944_3

Aug 28 '23 15:08 commy2

I tested on !TestAllFactions with Demo General.

Aug 28 '23 15:08 xezon

shot_20230828_174428_1 shot_20230828_174430_2

This map? Can't reproduce.

Aug 28 '23 15:08 commy2

Also works for pre-placed units:

shot_20230828_175104_1

Keep in mind that it will not work in loaded savegames. The special power module would not be added.

Aug 28 '23 15:08 commy2

I did forget the base defenses tho. Fixed.

Aug 28 '23 15:08 commy2

I got latest and now it works.

I see there is a little glitch with the command set after suicide. After pressing the suicide button, it shows the suicide ability reloading for a short moment before hiding the command set. Any way to avoid that?

Aug 28 '23 16:08 xezon

I tried a few things without success. I don't know how that would be possible. Sry.

Aug 28 '23 16:08 commy2

Perhaps we can upgrade the command set to an empty one?

Aug 28 '23 16:08 xezon

The Jarmen Kell and RPG Trooper are silent and without Demo explosion effect on Suicide.

Aug 28 '23 17:08 xezon

The Jarmen Kell and RPG Trooper are silent and without Demo explosion effect on Suicide.

The same appears to happen on main branch.

Aug 28 '23 17:08 commy2

Unrelated. Fixed in https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2307.

Aug 28 '23 20:08 commy2

Very nice! This hits 7 birds with one stone :D

Aug 29 '23 23:08 MTKing4