Nikolay Baklicharov

Results 53 comments of Nikolay Baklicharov

Hey again @StephanTLavavej Time passed, C++20 implementation of MS STL is completed(still waiting for a few fixes from WG, but nothing major). Do you have more clear idea when the...

The CI failed and it would seem that this validation is expected to be done ad-hoc based on the formatting string being passed. I.e. if there are invalid values into...

A single test on `x86 x86 8` failed: ``` 1: Failed Tests (1): 1: libc++ :: std/thread/thread.condition/thread.condition.condvarany/notify_one.pass.cpp:2 ``` However, this seems like a flaky test, unrelated to my PR. @StephanTLavavej...

> Thanks, this is looking really good! I'm about to fall asleep so I want to take another look at this, but here are the comments I noticed. All comments...

I've discovered I'm missing some cases. Will update the PR again soon.

Ok, now I think I've got all the cases covered (and perhaps brain damage). :) Btw, the tests are also compiling in C++14 mode. Is there any specific reason for...

I use VS and on save it didn't reordered the headers. Might be something on my end. Will check again. About force pushing. I did so exactly for readability reasons...

``` ********************************************************************** ** Visual Studio 2022 Developer Command Prompt v17.10.5 ** Copyright (c) 2022 Microsoft Corporation ********************************************************************** [vcvarsall.bat] Environment initialized for: 'x64' C:\Program Files\Microsoft Visual Studio\2022\Community>cd D:\Projects\Microsoft\STL C:\Program Files\Microsoft Visual...

You are correct. I use VS 17.10.5. I don't like using preview versions of the IDE as often they are buggy. A simple local change to `stl/inc/yvals_core.h` allows me to...

I see, yes. It's strange to hardcode paths for tools. This will not work even for the simple case if I install the IDE in another dir.