Crash on startup on High Sierra

[gilsonolegario]

In the new macOS High Sierra the Theremin.app crash just after it starts.

There is something broken with the playback controls [mWindow setToolbar:[_mainPlayerToolbarController toolbar]];

If the source code are compiled without the playback buttons everything is fine. But, of course, without the buttons on the toolbar.

[therealmuffin]

I suggest you try MPD client Cantata. It's multi platform and actively maintained:https://github.com/CDrummond/cantata From: [email protected]: 28 September 2017 7:25 amTo: [email protected] to: [email protected]: [email protected]: [TheStalwart/Theremin] Crash on startup (#29) In the new High Sierra the Theremin.app crash just after it starts. There is something broken with the playback controls [mWindow setToolbar:[_mainPlayerToolbarController toolbar]];

—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

[gilsonolegario]

Thanks for your suggestion. I know Cantata, but it consumes ~7% of CPU and ~80% more memory than Theremin. As I said, I compiled a version with no playback controls and I will live with that.

Thanks.

[musyne]

Can you share your compiled version? I just updated to high sierra and I already miss Theremin :(

[gilsonolegario]

Oh, great! I'm not the only one.

Of course, but as I said, it's only partially working.

https://drive.google.com/open?id=0B3pkQ71JfgdTTmVRRkc2X0FON3M

[musyne]

We might be the only 2!

[mkody]

Well, I've been waiting to see if there was a fix but your version do work. Thanks!

[saundersjr]

I too would like a fix.

[acy76]

You all are not alone. I would also love a fixed version, but I am a PHP dev and couldn't even get xcode to compile when I took a shot at a fix the other week. I confess to knowing next to nothing about mac os development, but I would be willing to assist in fixing this app. If anyone has resources, advice or wants to collaborate, please let me know.

[rgolan]

I'm experiencing the same crash on startup. I too would willing to help test fixes.

[gilsonolegario]

There is https://github.com/kampfgnu/Theremin/commits/master but is crashing here too

[rgolan]

@gilsonolegario : I really can't debug this but I can test as I mentioned. I installed your version without the playback buttons as I ususally use the keyboard shortcuts anyway. It appears kampfgnu is working on Theremin right now. Hopefully there will be a compiled version to test soon.

[kampfgnu]

try this: https://drive.google.com/file/d/17btcu5Dx9GU4yaQjYUostqLvO5OQqHz8/view?usp=sharing it is the compiled version of my master branch. i think it fixes the toolbar crash

[gilsonolegario]

Thanks for you response, @kampfgnu.

Your version crashes with

Crashing on exception: -[UnifiedToolbarLabelCell _compressibleOptionsForControlView:]: unrecognized selector sent to instance 0x60400011a8b0

[kampfgnu]

i'm running on sierra, so it is currently not possible for me to check this. but just add the function to UnifiedToolbarLabelCell.m file like i did for another toolbar crash:

• (BOOL)_anySegmentShowsBadge { return NO; }
• (BOOL) _compressibleOptionsForControlView { return NO; }

i am not sure, if compressibleOptions... returns a BOOL, but just add the missing functions to this file. this should fix it.

cheers!

[gilsonolegario]

only adding the function to UnifiedToolbarLabelCell.m doesn't work. But your commit solves the problem.

Many thanks!

[rgolan]

Is there a compiled version with this fix I can try out?

Thanks.

— Ron Golan

On Dec 20, 2017, at 10:53 AM, Gilson Olegario [email protected] wrote:

only adding the function to UnifiedToolbarLabelCell.m doesn't work. But your commit https://github.com/pweiskircher/Theremin/pull/2 solves the problem.

Many thanks!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/TheStalwart/Theremin/issues/29#issuecomment-353150784, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGzr8wE6IIcostyaTQ5ZGKuBJQbfp22ks5tCVe_gaJpZM4PmsfN.

[gilsonolegario]

Here @rgolan

[rgolan]

Thank you!

— Ron Golan

On Dec 20, 2017, at 11:13 AM, Gilson Olegario [email protected] wrote:

Here https://drive.google.com/file/d/1kAh1V-RdhxrfvANZBFgpCcSwW6FEToIb/view?usp=sharing @rgolan https://github.com/rgolan — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TheStalwart/Theremin/issues/29#issuecomment-353155825, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGzr3pD05rqZ5cKTlE5NpU0pQi648WHks5tCVxNgaJpZM4PmsfN.

[khgantz]

Thank you! As a non programmer I had almost given up on a fix for Theremin. I use it to play stuff on antique radios that I've gutted and converted to Raspberry Pi music players. Examples are at https://youtu.be/6aU0hzXlWcU and https://youtu.be/SG2tHZRswO8 . Now, if only someone would fix mpod for iOS .. :-)

Again, thank you very much!

[kampfgnu]

btw. i added the current build here: https://github.com/kampfgnu/Theremin/releases any future updates will be released over there.

@khgantz i just sent an email to the guy who created mPod, offering him my help to get the app up and running. let's see if this will work out.

i keep you posted, cheers!

[khgantz]

Wow! Thanks! @kampfgnu

On Feb 4, 2018, at 8:04 PM, kampfgnu [email protected] wrote:

btw. i added the current build here: https://github.com/kampfgnu/Theremin/releases https://github.com/kampfgnu/Theremin/releases any future updates will be released over there.

@khgantz https://github.com/khgantz i just sent an email to the guy who created mPod, offering him my help to get the app up and running. let's see if this will work out.

i keep you posted, cheers!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TheStalwart/Theremin/issues/29#issuecomment-362956364, or mute the thread https://github.com/notifications/unsubscribe-auth/AidM3RC45kg0kvrUIBDicwCnJI0D6vOIks5tRlOwgaJpZM4PmsfN.

[trafferty]

Thanks @kampfgnu !!

[opfeifer]

Awesome! So great someone still cares for this. Running fine here on High Sierra 10.13.4!

[rabb1t]

Thanks @kampfgnu! Runs smoothly on macOS Mojave v10.14.3!

[bobbygeewow]

Yes! Thank you also kampfgnu!

[herrernst]

Unfortunatley, @kampfgnu's build also crashes for me on macOS Catalina: Assertion failed: (_eventPort != NULL), function -[SPMediaKeyTap startWatchingMediaKeys], file /Users/kampfgnu /Documents/Programming/OSX_projects/Theremin/ThereminFork/Source/SPMediaKeyTap/SPMediaKeyTap.m, line 76.