chef-vsftpd icon indicating copy to clipboard operation
chef-vsftpd copied to clipboard

Merge features from optiflows-cookbooks/vsftpd

Open guilhem opened this issue 10 years ago • 10 comments

Hi @TheSerapher

I'm happy to see a updated cookbook for vsftpd.

Months ago I forked https://github.com/cwjohnston/chef-vsftpd to https://github.com/optiflows-cookbooks/vsftpd and updates some parts.

It would be cool to merge some features like LWRP for virtual users etc.

guilhem avatar Sep 20 '14 12:09 guilhem

I think that's a great idea. I can look into it or you can even PR the changes. I will merge into next and adjust if needed.

TheSerapher avatar Sep 20 '14 16:09 TheSerapher

I just checked your cookbook @guilhem and I like it. A lot of additions that I never got around to add (like CB included user management, very nice). Mine was pretty basic and did what I needed back then, but it sure could need some love to make it usable for others too.

Maybe your version should be used instead? That is if you are able to maintain it.

TheSerapher avatar Sep 21 '14 08:09 TheSerapher

@TheSerapher My version is more advanced in some points yes. but need some improvements. If you want, I can make it even better (some syntax to clean up) then push it on: http://github.com/redguide (I push there cookbooks to be maintain without any personal/enterprise problem/ego) then add you as contributor for any further update.

guilhem avatar Sep 22 '14 23:09 guilhem

That sounds great. Maybe we can even get Supermarket permissions placed on our project instead so we can start uploading it for others to use.

TheSerapher avatar Sep 23 '14 04:09 TheSerapher

hi @TheSerapher I didn't really understand you last message ^^ But in the meantime I've updated my cookbook with some cool features like auto generated vsftpd.conf \o/ (and correct all foodcritic / rubocop issues :angel: ).

guilhem avatar Sep 23 '14 13:09 guilhem

Supermarket.getchef.com

It's used by tools like knife and berkshelf to auto discover a cookbook. Currently the vsftp cookbook there is probably and older outdated version.

I shall take a look at your cookbook. If that works well we can close my repo and I point them towards yours.

TheSerapher avatar Sep 25 '14 04:09 TheSerapher

@TheSerapher I believe the only way currently to change ownership of the vsftp cookbook on supermarket.getchef.com is to reach out to the current owner and ask him/her to change ownership.

damacus avatar Oct 28 '14 09:10 damacus

Thanks for the info, that will probably make it rather complicated since I am not sure if that user is reachable or active at all ..

TheSerapher avatar Oct 28 '14 10:10 TheSerapher

I shall try and get you some details, apparently he is very approachable, so I'm sure we can work something out :)

damacus avatar Oct 28 '14 10:10 damacus

Looks like there are some contact details on his github profile: https://github.com/rberger

damacus avatar Oct 28 '14 10:10 damacus