TheRealNoob
TheRealNoob
I'm familiar with the setup, I'm using it at my company. We also have alloy picking up PrometheusRule objects and shipping them to remote Mimir, and because of that we...
That's an interesting thought about disabling just the validating webhook from KPS. I wonder if operator would still complain in that scenario, where the webhook doesn't exist nor does the...
This is interesting. If I'm reading this right, it doesn't look like KPS supports the validating webhook for alertmanager, only for prometheusRule. KPS chart only lists prometheusRule https://github.com/prometheus-community/helm-charts/blob/a5ec1c97409f83d024253ded8881f6486c7463b8/charts/kube-prometheus-stack/templates/prometheus-operator/admission-webhooks/validatingWebhookConfiguration.yaml#L14 admission-webhook chart...
>@achetronic I think that running the Prometheus Operator admission webhook (as a standalone component) to validate PrometheusRules CR only so they can be loaded into Mimir via Grafana Alloy is...
can you share your loki config file please? also how many pods running on your cluster?
I opened another PR https://github.com/dexidp/helm-charts/pull/132 on this a long time ago as well. I know I'm biased, but I like my solution more as it allows extraObjects to be a...
I've not run across any other charts currently allowing `extraObjects` to be a dictionary, only a list; let alone either. With that in mind I understand your point, but I...
I understand the stance you're making, and I've made it myself many a time. In this instance I'm stating that I believe my change to have no negative drawbacks for...
as far as I know it's ready to be merged
LGTM. I don't think you should need to run `make helm-docs` with this change, but we'll see when the tests run.