remix-auth-socials icon indicating copy to clipboard operation
remix-auth-socials copied to clipboard

LinkedIn Strategy (another package)

Open Lzok opened this issue 2 years ago • 3 comments

Hi, how are you?

I'm just passing here to show you I made a package for LinkedIn Strategy. I red your message in this other issue of yours and you have valid points.

I documented the code, made tests and export some other things among the main class. Here is the source code to look at it

Let me know how you see it, if you consider i am missing something for you so you can re-export from there. Feedback and suggestions are welcome.

Have a nice Saturday!

Lzok avatar Feb 05 '22 15:02 Lzok

Hey!

Sorry I took so long on this. I will be re-exporting third party packages soon!

TheRealFlyingCoder avatar Mar 17 '22 23:03 TheRealFlyingCoder

@TheRealFlyingCoder Awesome!

Let me know if I can help with something

Lzok avatar Mar 25 '22 14:03 Lzok

Any update on the LinkedIn Strategy export?

bluefire2121 avatar Aug 01 '22 05:08 bluefire2121

@Lzok and @bluefire2121 boy am I sorry this took so long!!!!!

I've just had all the social auth packages (bar facebook) approve my PR's to ensure they offer a consistent experience, and released V2 of the package.

@Lzok have a look at the google package and once you've updated remix-auth-linkedin to match the experience open a PR to add it here :)

We just need scopes as either scopes?: LinkedinScopes[] | string as well as a LinkedInStrategyDefaultName export... Essentially just follow the pattern and we'll be good :)

TheRealFlyingCoder avatar Jan 04 '23 00:01 TheRealFlyingCoder