James Falcon
James Falcon
@blackboxsw and @chifac08 , I have a feeling you're both waiting for the other. @chifac08 , since your last push, is this ready for re-review?
@blackboxsw or @aciba90 , are we waiting on anything else here?
@dark2phoenix , this PR still isn't setup correctly. You need to rebase your branch against main such that changes from #4763 are taken into account. @sshedi , since you provided...
On https://github.com/dark2phoenix/cloud-init/ , there should be a `Sync fork` option. You could try that and see if you can pull after doing that. Otherwise, you'll need to make sure your...
We can reopen this one if you push to the same branch. Otherwise, you can open a new PR. It's up to you.
@holmanb this still WIP?
I think we can simplify a bit more, can't we? ```diff diff --git a/cloudinit/net/netplan.py b/cloudinit/net/netplan.py index fe97fdcc9..46cbe3a9d 100644 --- a/cloudinit/net/netplan.py +++ b/cloudinit/net/netplan.py @@ -250,11 +250,9 @@ def netplan_api_write_yaml_file(net_config_content: str) ->...
Thanks for the bug report @philsphicas . Looks like [networkd.py](https://github.com/canonical/cloud-init/blob/main/cloudinit/net/networkd.py#L195) needs an update.
@philsphicas , no sorry about the wait on that. I'll try to get it reviewed this week.
We're still waiting on the CLA for this PR, correct? Any updates?