Kendra Neil comments

Results 136 comments of


                                            Kendra Neil

fix(route53): vpc region in template overridden by stack region

Rebasing gets weird sometimes ¯\\\_(ツ)\_/¯

fix(route53): vpc region in template overridden by stack region

@merigifyio update

fix(route53): vpc region in template overridden by stack region

> @TheRealAmazonKendra Is this mergify command new? Never saw this before and wondered if we should use it instead of the GitHub Update Branch command :) I use it because...

fix(route53): vpc region in template overridden by stack region

New/updated integration tests actually create the resources and deploy them. They just don't run in a public account so you never see it happen. We also will see from the...

fix(route53): vpc region in template overridden by stack region

> @TheRealAmazonKendra I have added your suggested changes. Thanks for the feedback! Regarding the integration tests: Do you mean Integration Tests for the `fromLookup` and `fromVpcAttributes` methods? I wonder if...

fix(route53): vpc region in template overridden by stack region

> @TheRealAmazonKendra Sorry for not working on this consistently - I have a lot on my plate right now. I have now added the integration tests for `fromLookup` and `fromVpcAttributes`...

fix(route53): vpc region in template overridden by stack region

FYI - I haven't forgot this PR but I do think there's more refactoring that needs to be done so I'm taking a deeper dive into the code to make...

fix(route53): vpc region in template overridden by stack region

@Mergifyio update

feat(ecs): add `maxSwap` and `swappiness` properties to LinuxParameters

@flavioleggio Apologies for the long wait on this. I've run the test that you wrote and pushed the result to an `expected` file. Please take a look and ensure that...

feat(ecs): add `maxSwap` and `swappiness` properties to LinuxParameters

@flavioleggio Well, this is my bad. I didn't notice that the integration test was the old style and not the new. We'll need to update to the new style. I'll...