harpoon icon indicating copy to clipboard operation
harpoon copied to clipboard

fix #565: setup data after config loaded

Open rndev-io opened this issue 10 months ago • 3 comments

rndev-io avatar Apr 11 '24 15:04 rndev-io

@rusnasonov thank you for the PR.

What about leaving the data initialization and sync_on_change function also inside Harpoon::new() and edit Harpoon::setup() like you did but with sync_on_change(self) moved right before the final return?

akyrey avatar Apr 11 '24 16:04 akyrey

What about leaving the data initialization and sync_on_change function also inside Harpoon::new()

It's creates additional empty data file with default key, which will never be used. If it's ok - why not.

but with sync_on_change(self) moved right before the final return?

Ok

rndev-io avatar Apr 11 '24 16:04 rndev-io

This also fixes #577

maxrzaw avatar May 21 '24 23:05 maxrzaw