BunSpreader icon indicating copy to clipboard operation
BunSpreader copied to clipboard

Fastify implementation has fixed time_in_queue

Open therealshark opened this issue 2 years ago • 1 comments

The fastify server has a route with a parameter /json/time_in_queue but this parameter is never used, instead the variable is hardcoded to 15000: https://github.com/ThePrimeagen/BunSpreader/blob/ca02db8e484e48de09c8f9b457d2bec1862a286b/src/fastify.js#L57

I would assume this changes the behavoir (and therefore the benchmark results) quite a bit, depending on what the client is sending. Am i missing something?

therealshark avatar Jul 12 '22 20:07 therealshark

So, I forgot that I never fixed that. I just made all of the request do 15 seconds for the test. That means they are all technically equal. Despite potential slowdowns and fastify (me) actually parsing things correctly.

ThePrimeagen avatar Jul 13 '22 00:07 ThePrimeagen