Exegol icon indicating copy to clipboard operation
Exegol copied to clipboard

Mount /etc/localtime on macOS with Orbstack

Open cHJlaXpoZXI opened this issue 1 year ago • 3 comments

Description

This PR is to delete line that block Orbstack to mount /etc/localtime. Orbstack on macOS can mount this folder proprely now. I have tested several time (no option, VPN and Desktop) and no issue, the time is sync with the host !

Related issues

No related issue

Point of attention

Hope that my modification is correct :)

cHJlaXpoZXI avatar Dec 19 '23 17:12 cHJlaXpoZXI

@QU35T-code can you confirm?

ShutdownRepo avatar Dec 19 '23 18:12 ShutdownRepo

Thank you for the PR. We need to do some testing before merging.

Regarding your code, my only concern is because of the docker-desktop patch: path_match = path_match.replace("/etc/", "/private/etc/")

Not sure if it's necessary when using orbstack or not

Dramelac avatar Dec 20 '23 23:12 Dramelac

Thank you for the PR. We need to do some testing before merging.

Regarding your code, my only concern is because of the docker-desktop patch: path_match = path_match.replace("/etc/", "/private/etc/")

Not sure if it's necessary when using orbstack or not

Orbstack mount the /etc/localtime by default. So I guess no. I haven't delete it because I don't know if this was used somewhere else or not.

If not, we can remove everything then.

And sure for testing no problem ;) if I can contribute with test, tell me ;)

cHJlaXpoZXI avatar Dec 21 '23 14:12 cHJlaXpoZXI

@ShutdownRepo or @QU35T-code Can you confirm Orbstack can bind volume from /etc ? Can you also test with Docker Desktop if it works or not ?

Dramelac avatar Jul 08 '24 19:07 Dramelac