[FEATURE] Sync grim reveal state when joining a lobby or refreshing during Grim Reveal

[portaux]

Description

When refreshing in the middle of a grim reveal, the entire grim gets revealed to you.

When joining a lobby during a grim reveal, sometimes you do not see any characters at all, even at the end of the reveal.

Steps to reproduce

Refresh a lobby during grim reveal, or join a lobby during grim reveal.

Browser

Chrome

Operating System

Mac

Date and Time

Feb 15th, 2025 (and a time before as well approx a month ago)

Game Session

https://botc.app/join/madness

Relevant console log output

[gareth]

Hi @portaux!

You're right about this, this is a side effect of how the grim reveal works. The server sends all of the roles to the browser at the start of the grim reveal and then just tells the browser when to turn over each token. For that reason, refreshing or joining partway through the reveal leads to the outcome you mention.

While it seems unexpected, we don't consider this a bug, as joining the session mid-reveal isn't something we specifically support. It would be nice to improve this, but it's not as simple a change as you might think, so it's not something we are likely to work on in the near future.

[portaux]

Hi Gareth,

Thank you for your email. I appreciate your reply and I agree, it's not a critical bug.

Thanks again,

On Sun, Feb 16, 2025 at 5:54 AM Gareth Adams @.***> wrote:

Hi @portaux https://github.com/portaux!

You're right about this, this is a side effect of how the grim reveal works. The server sends all of the roles to the browser at the start of the grim reveal and then just tells the browser when to turn over each token. For that reason, refreshing or joining partway through the reveal leads to the outcome you mention.

While it seems unexpected, we don't consider this a bug, as joining the session mid-reveal isn't something we specifically support. It would be nice to improve this, but it's not as simple a change as you might think, so it's not something we are likely to work on in the near future.

— Reply to this email directly, view it on GitHub https://github.com/ThePandemoniumInstitute/botc-release/issues/309#issuecomment-2661443180, or unsubscribe https://github.com/notifications/unsubscribe-auth/BPRMVOVB6AENTLBTTZP7E4T2QCKDBAVCNFSM6AAAAABXG3XS4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRRGQ2DGMJYGA . You are receiving this because you were mentioned.Message ID: @.***> [image: gareth]gareth left a comment (ThePandemoniumInstitute/botc-release#309) https://github.com/ThePandemoniumInstitute/botc-release/issues/309#issuecomment-2661443180

Hi @portaux https://github.com/portaux!

You're right about this, this is a side effect of how the grim reveal works. The server sends all of the roles to the browser at the start of the grim reveal and then just tells the browser when to turn over each token. For that reason, refreshing or joining partway through the reveal leads to the outcome you mention.

While it seems unexpected, we don't consider this a bug, as joining the session mid-reveal isn't something we specifically support. It would be nice to improve this, but it's not as simple a change as you might think, so it's not something we are likely to work on in the near future.

— Reply to this email directly, view it on GitHub https://github.com/ThePandemoniumInstitute/botc-release/issues/309#issuecomment-2661443180, or unsubscribe https://github.com/notifications/unsubscribe-auth/BPRMVOVB6AENTLBTTZP7E4T2QCKDBAVCNFSM6AAAAABXG3XS4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRRGQ2DGMJYGA . You are receiving this because you were mentioned.Message ID: @.***>