WebAccessibilityToolbar icon indicating copy to clipboard operation
WebAccessibilityToolbar copied to clipboard

Crash rendering aViewer unusable

Open matatk opened this issue 9 years ago • 10 comments

Reported initially by @patrickhlauke

It seems a recent IE11 update may have triggered this. Bringing the IE window to the foreground when running aViewer results in the following crash:

Unhandled exception at 0x00612021 in Aviewer.exe: 0xC000041D: An unhandled exception was encountered during a user callback.

@jun325: please could you have a look at this? Unfortunately, it has made aViewer unusable for us and clients.

matatk avatar Mar 05 '15 10:03 matatk

I can't reproduce it. Do you have other information?

ghost avatar Mar 05 '15 11:03 ghost

This happens on Win8.1/IE11. Also, I was using the standalone aViewer, not the one from the WAT (but I can trigger the same behavior when using that one).

The specific IE11 version is 11.0.9600.17631, Update Versions: 11.0.16 (KB3021952)

Setting aViewer to Watch Focus and then clicking into IE (simply bringing the window to the foreground is enough) consistently crashes aViewer for me (and one of our clients, who flagged this up). It does work fine using Chrome and Firefox.

patrickhlauke avatar Mar 05 '15 11:03 patrickhlauke

I'm using the same version. but, my aViewer works fine... I don't understand the cause so far.

ghost avatar Mar 05 '15 15:03 ghost

Is it something to do with registering the DLL (I've never really known why and when I should be doing that)? I haven't been able to reproduce it either so far, but it clearly 'is a thing' for several aViewer users.

matatk avatar Mar 05 '15 15:03 matatk

Any dll file is not registered for IE.

ghost avatar Mar 05 '15 16:03 ghost

I deleted the auxiliary function for IE. The AViewer get the IWebBrowser2 interface by using this function. Please try it. https://github.com/jun325/WebAccessibilityToolbar/commit/92021f6dbacc5c164962f1b388b7a148be1969da

ghost avatar Mar 07 '15 06:03 ghost

Thank Jun - confirming that the test version you provided does work now with IE11 on my system, without any crashes.

patrickhlauke avatar Mar 07 '15 10:03 patrickhlauke

@jun325 thanks for fixing this! I've been trying to work out how to merge the new aViewer into our main repo, but I can't seem to figure it out (when I try to make a pull request between the commit you linked to above and our main branch, it says that things like Translations.ini have changed, but it can't give me a diff -- but you fixed that issue for us some time ago).

You've got commit access to the main repo -- would it be possible for you to make a branch off of master for this fix (only), put the new aViewer in there and then make a Pull Request? If you start from master in this repo, then you should have the UTF-8 Translations.ini and all the other fixes included already. Though this is just my suggestion -- if you would prefer to do it another way, let us know.

matatk avatar Mar 09 '15 09:03 matatk

@matatk: It is not solved. We do not understand the cause of an issue. The test version is a temporary repair. I am NOT requesting merging. Let's continue this talk when I send odd PR.

ghost avatar Mar 09 '15 13:03 ghost

@jun325: ah, I was going too far ahead there. Thanks for the clarification.

matatk avatar Mar 09 '15 14:03 matatk