theodinproject
theodinproject copied to clipboard
Feature: move commit lesson to Git Basics section
Complete the following REQUIRED checkboxes:
- [X] I have thoroughly read and understand The Odin Project Contributing Guide
- [X] The title of this PR follows the
keyword: brief description of change
format, using one of the following keywords: -
Feature
- adds new or amends existing user-facing behaviour -
Chore
- changes that have no user-facing value, refactors, dependency bumps, etc -
Fix
- bug fixes
Complete the following checkbox ONLY IF it is applicable to your PR. You can complete it later if it is not currently applicable:
- [ ] I have verified all tests and linters pass against my changes, and/or I have included automated tests where applicable
1. Because: I am going through the Foundations course, and got a bit of whiplash going from HTML to a seemingly random commit lesson. I believe that this lesson is here as a sort of refresher before people create their first batch of project commits, but I feel like it fits better within the Git Basics section.
2. This PR:
- Moves the commit lesson in
db/fixtures/lessons/foundation_lessons.rb
3. Additional Information: I didn't think this was worth opening an issue for, but feel free to close this PR if it warrants more discussion first.
Hey @bradleycamacho, thanks for taking the time do this 💪
The placement of the lesson was very intentional. We wanted to have it in close proximity to where that knowledge will be useful (right before the first project). But I can understand it being jarring. I could personally go either way with it being moved or staying where it is. Later in the course might even be better as there is a lot to take in during the early sections of foundations imo.
I think our best path to consensus would be with opening an issue first. That will give more learners/maintainers an opportunity to weigh in on what they think. Would you like to create an issue?