javascript-exercises icon indicating copy to clipboard operation
javascript-exercises copied to clipboard

NPM Vulnerabilities Warning

Open ArcaneIRE opened this issue 3 years ago • 1 comments

After running npm install as directed in the readme, I was shown a 'vulnerability' warning. Screenshot from 2022-05-14 13-46-42

From what I can gather, I'm supposed to ignore these. However, a 'critical' warning implies that it should be attended to.

Since this is the first use of npm install in the course, maybe it would be a good idea to add a mention of the audit feature the readme?

ArcaneIRE avatar May 14 '22 12:05 ArcaneIRE

The vulnerabilities can be audited and fixed by running the command 'npm audit fix'. Can you please assign it to me so that I can update the readme for the following issue?

MahirMahdi avatar Aug 04 '22 02:08 MahirMahdi

This is still an issue and comes up in support in discord. Seems to me a two prong approach would work.

  1. Update readme to indicate that this may occur and is no big deal
  2. Update the package with current versions so the warnings are gone, at least for the moment.
  • This would require testing all the excersises to ensure they all still work.

If this approach is approved, please asssign and I will do so.

@ManonLef - Can you look at this, I was going to open an issue on this, but found this very old one.

UniquePixels avatar Jul 21 '23 01:07 UniquePixels

anyone of the @TheOdinProject/javascript maintainers team that could have a look at this?

ManonLef avatar Jul 21 '23 16:07 ManonLef

Any feedback on this?

UniquePixels avatar Aug 02 '23 02:08 UniquePixels

@fabulousgk's plan sounds good to me

wise-king-sullyman avatar Aug 22 '23 01:08 wise-king-sullyman