curriculum icon indicating copy to clipboard operation
curriculum copied to clipboard

API Basics: Hyperlink at the Knowledge check's last question is not referencing to the targeted page

Open gxaurab opened this issue 8 months ago • 7 comments

Checks

Describe your suggestion

ImageI think the last question is redirecting towards a different link, it's the link same as of the "RESTful API design"

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/nodejs-api-basics

(Optional) Discord Name

No response

(Optional) Additional Comments

Would like to contribute

gxaurab avatar Apr 28 '25 00:04 gxaurab

Hello @gxaurab thank you for your interest in contributing to the curriculum.

So just to understand the issue more thoroughly: your problem is that the knowledge check link points to an outside resource?

If you have some other place within the lesson you'd like to point the link, I could be interested in hearing that out. But a knowledge check pointing to an outside resource isn't considered problematic and is done elsewhere throughout the curriculum. Our LAYOUT_STYLE_GUIDE (scroll down to the 5th point about knowledge checks) also explicitly mentions that they're allowed to link to outside content if that content was linked in the lesson, which is the case with this knowledge check you're pointing out.

JoshDevHub avatar Apr 29 '25 16:04 JoshDevHub

Hi @JoshDevHub , I would like to work on this issue. I believe the problem doesn't lie in the link pointing to an outside resource but rather to the wrong resource. The hyperlink should point to the (POST, GET, PUT, DELETE) table that's already in the same page as the lesson as that should be the appropriate resource to answer the question "Which HTTP verb does each letter in CRUD (Create, Read, Update, Delete) correspond to?" Thanks

NickBzy avatar Apr 29 '25 22:04 NickBzy

@NickBzy Thank you for your interest in contributing.

I could be okay with linking to that table in the lesson. However, because the author of this issue checked the box saying they want to work on it, they have priority with submitting a PR for the issue.

@gxaurab Are you still interested in submitting a PR for this? If yes, I'll assign you, and if not, I can assign NickBzy.

JoshDevHub avatar May 01 '25 18:05 JoshDevHub

Sure. I am still interested

gxaurab avatar May 01 '25 23:05 gxaurab

hello? I am interested in any open source projects to contribute to so please feel free to assign me

gxaurab avatar May 07 '25 12:05 gxaurab

It's been assigned to you @gxaurab, let us know if you need any help!

KevinMulhern avatar May 07 '25 12:05 KevinMulhern

This issue is stale because it has had no activity for the last 30 days.

github-actions[bot] avatar Jun 07 '25 02:06 github-actions[bot]

@gxaurab any updates on this?

KevinMulhern avatar Jul 17 '25 15:07 KevinMulhern

This issue is stale because it has had no activity for the last 30 days.

github-actions[bot] avatar Aug 18 '25 02:08 github-actions[bot]

Was fixed back in #29681, just not correctly linked.

mao-sz avatar Sep 08 '25 11:09 mao-sz