curriculum icon indicating copy to clipboard operation
curriculum copied to clipboard

Replace flickr with pexels

Open NikEmman opened this issue 9 months ago • 7 comments

Because

Many users have reported encountering issues with the Flickr API project within TheOdinProject curriculum. Specifically, problems include difficulties with signing in, logging in, and frequent "Account creation failed" errors.

This PR

  • Replaces Flickr service / instructions, with similar ones for Pexel.

Issue

Closes #28285

Additional Information

Pull Request Requirements

  • [x] I have thoroughly read and understand The Odin Project curriculum contributing guide
  • [x] The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • [x] The Because section summarizes the reason for this PR
  • [x] The This PR section has a bullet point list describing the changes in this PR
  • [x] If this PR addresses an open issue, it is linked in the Issue section
  • [x] If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • [x] If any lesson files are included in this PR, they follow the Layout Style Guide

NikEmman avatar Apr 01 '25 16:04 NikEmman

I just reached the flicker API lesson, got stuck, then went through the Pexel lesson you are proposing. Seemed to go pretty smooth (pictured below).

Some small feedback : 4. Upload a few photos to your account! Then add them to a collection. Select the created collection, the URL will look like ` https://www.pexels.com/collections/collectionTitle-collectionIDhere/`. An example would be `adkmjqz`. You'll need that later for some of the API methods.

There was some friction trying to upload some random photos. They want a certain quality (and megapixel) and my photos were being rejected. I found an easy workaround is that instead of uploading photos, you can browse the front page and add some photos quickly to your collection by hovering your mouse over the photo and pressing the collect icon in the top right.

A potential reword could be something like: 4. Browse the website for some photos then add them to a collection (or add your own!). Navigate to your created collection, and notice the URL will look like ` https://www.pexels.com/collections/collectionTitle-collectionIDhere/`. An example would be `adkmjqz`. You'll need that later for some of the API methods.

image

Ty @NikEmman for making this. Hope it gets reviewed soon :smile:

terryclayton avatar Apr 04 '25 21:04 terryclayton

@JoshDevHub Fixed the md lint issues. Thanks for your detailed answer, made it easy!

NikEmman avatar Apr 05 '25 16:04 NikEmman

I think the linting issues are fixed. My bad, should have caught this earlier and not waste more of your time. I would like to try to do the full work and submit the PR to the main site repo, if that is OK with you. Would be a fool to pass on learning opportunities! Thanks once again for your thorough answers :+1:

NikEmman avatar May 02 '25 06:05 NikEmman

Thanks @NikEmman and @JoshDevHub for working on this issue. Its been there for such a long time and its great how its finally getting fixed!

AhmedTheGreatest avatar May 02 '25 11:05 AhmedTheGreatest

@JoshDevHub

Are you still working on this one mate?

CouchofTomato avatar May 12 '25 12:05 CouchofTomato

@JoshDevHub I'm working on it. Should I encounter any problems, I will definitely ask, thanks for offering! Will have it ready asap!

NikEmman avatar May 28 '25 09:05 NikEmman

@JoshDevHub Ok the changes are done one the main project ( on my local fork / branch) . But i have a few questions!

  • Should I just go ahead and make the pull request?
  • Should I mention this issue as relevant?
  • On the main project I see that the commits have a certain style for the title, like Feature: This is a new feature. For consistency, I'm thinking I should title the commit something like Update: Replace Ruby On Rails / Flickr API with Ruby On Rails /Pexels API.

Thanks in advance for your time!

NikEmman avatar May 29 '25 06:05 NikEmman