curriculum icon indicating copy to clipboard operation
curriculum copied to clipboard

Git Section Working with Remotes Lesson: The GitHub workflow SVG needs to be in the next lesson

Open StewardRighteous opened this issue 9 months ago • 6 comments

Checks

Describe your suggestion

The "working with remote" lesson starts with the SVG of the workflow diagram of TOP repository(in order to contribute). But the appropriate place this picture would make sense will be the next lesson - "Using Git in Real Life" where the lesson actually talks about How to contribute to the curriculum. The picture has upstream repository in it which is introduced in the next lesson.

working with remote : https://www.theodinproject.com/lessons/javascript-working-with-remotes Using Git in Real Life : https://www.theodinproject.com/lessons/javascript-using-git-in-the-real-world

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/javascript-working-with-remotes

(Optional) Discord Name

No response

(Optional) Additional Comments

I was reading this lesson yesterday and I realized this problem. Since, I am currently on the lesson that tells me to contribute to the curriculum. I am very much excited to work on this issue(If I get it 😅). TOP has been so great and taught me a lot so far. I am grateful for that.

StewardRighteous avatar Mar 08 '25 08:03 StewardRighteous

I agree, it would make more sense in the next lesson.

Thanks for making this issue and volunteering to contribute!

wise-king-sullyman avatar Mar 14 '25 19:03 wise-king-sullyman

This issue is stale because it has had no activity for the last 30 days.

github-actions[bot] avatar Apr 14 '25 02:04 github-actions[bot]

@StewardRighteous Do you still have any interest in putting in a PR for this issue?

JoshDevHub avatar Apr 18 '25 19:04 JoshDevHub

Yess. I have interest in putting this PR

StewardRighteous avatar Apr 19 '25 02:04 StewardRighteous

@StewardRighteous Do you still have any interest in putting in a PR for this issue?

Yess. I have interest in putting this PR. Sorry I had no idea how to reply to you, I thought my last reply would give you a notification.

StewardRighteous avatar May 09 '25 05:05 StewardRighteous

This issue is stale because it has had no activity for the last 30 days.

github-actions[bot] avatar Jun 09 '25 02:06 github-actions[bot]

Hi @StewardRighteous, thanks for putting this issue together. Given it hasn't had any movement in a couple of months, we'll let someone else have a crack at it.

KevinMulhern avatar Jul 17 '25 15:07 KevinMulhern

Hi @KevinMulhern , I want to help with this PR.
I read the two lessons mentioned and in the event I am assigned this task, it would be necessary to specify if TOP wants to move only the picture or the whole section "Workflow diagram".

scenario 1

  • If the entire section "Workflow diagram" is moved, the place indicated in the next lesson would be after "Commit messages for collaboration" section and before "Assignment" section.
  • the first question in the Knowledge check needs to move as well.
  • and the using remotes to change history lesson overview would need more context.

scenario 2

  • If only the picture is moved, the new place in the next lesson will be the same, after "Commit messages for collaboration" section and before "Assignment" section, with the same title "Workflow diagram".
  • in the initial lesson the title of the section "Workflow diagram" would need to be changed for a more appropriate one with the content that remained.
    I hope I can help with this

manelly67 avatar Jul 19 '25 00:07 manelly67

Thanks @manelly67 - really appreciate how much thought you’ve already put into this. I’ve gone ahead and assigned it to you.

Just to double-check I’m on the same page: when you say "the entire section," are you including the content about git push --force as well?

KevinMulhern avatar Jul 19 '25 12:07 KevinMulhern

Hi @KevinMulhern , thank you for the assignment.
Yes, when I said the entire section I am referring to including the content about git push --force. Because under the title "Workflow diagram" there are the two introductory lines, the image and the content git push --force.

In this order of ideas, in scenario 2 ( that looks like the most reasonable ) the git push --force content remains where it is, but giving the "git push --force" subtitle a new style as title format.

However, I would like to know: the aside section containing the lesson content, is not located in the curriculum repository. So, The markdown format change is sufficient for it to be read and included in aside section lesson content?. Because in both lessons the content would be changing.

Let me know your opinion to start working on this. Thanks

manelly67 avatar Jul 19 '25 16:07 manelly67

Thanks for clearing that up @manelly67 - I agree, scenario 2 sounds like the most reasonable approach and the way to go.

So, the markdown format change is sufficient for it to be read and included in aside section lesson content?

Yep, exactly! The aside content is automatically generated from the markdown based on the titles, so your markdown changes will take care of it.

KevinMulhern avatar Jul 19 '25 16:07 KevinMulhern

Thank you @KevinMulhern , I will start working on this.

manelly67 avatar Jul 19 '25 17:07 manelly67