curriculum icon indicating copy to clipboard operation
curriculum copied to clipboard

Form Validation with JavaScript: <clarify Instructions for an exercise>

Open GaneshS288 opened this issue 10 months ago • 6 comments

Checks

Describe your suggestion

Problem

There is an exercise about adding form validation to a previous project 'Library' (link below) https://www.theodinproject.com/lessons/node-path-javascript-library

Image

The instructions tell learners to 'not let users submit the form without filling in all fields`. However prior to the Library projects you have learned native form validation so most learners must've used required attribute on their form input fields.

This can create confusion for the learners as the form is already handling empty fields.

Suggestions

We could change the instructions to tell learners that they shoudl display custom error messages instead of the default "Please fill out this field". So the exercise paragraph would look like this.

  • Go back to your ‘Library’ project and add validation to that form! Display a custom error message when the user tries to submit an empty form field (eg. "The author name must be filled"). Don’t forget to use the git branch workflow you learned in Revisiting Rock Paper Scissors from Foundations to work on a new feature

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/node-path-javascript-form-validation-with-javascript

(Optional) Discord Name

evilganesh

(Optional) Additional Comments

No response

GaneshS288 avatar Feb 25 '25 09:02 GaneshS288

This issue is stale because it has had no activity for the last 30 days.

github-actions[bot] avatar Mar 28 '25 02:03 github-actions[bot]

Bumped

GaneshS288 avatar Mar 28 '25 02:03 GaneshS288

@TheOdinProject/javascript Does anyone have an opinion on this?

CouchofTomato avatar Mar 28 '25 12:03 CouchofTomato

This issue is stale because it has had no activity for the last 30 days.

github-actions[bot] avatar Apr 28 '25 02:04 github-actions[bot]

Bump

GaneshS288 avatar Apr 28 '25 02:04 GaneshS288

This issue is stale because it has had no activity for the last 30 days.

github-actions[bot] avatar May 29 '25 02:05 github-actions[bot]

This issue is stale because it has had no activity for the last 30 days.

github-actions[bot] avatar Sep 03 '25 02:09 github-actions[bot]

Sorry this slipped through the cracks, @GaneshS288 I like the suggested change

mao-sz avatar Sep 10 '25 23:09 mao-sz