curriculum icon indicating copy to clipboard operation
curriculum copied to clipboard

All lessons: Remove/replace Replit suggestions

Open Eduardo06sp opened this issue 1 year ago • 6 comments

Because

we are removing Replit from the curriculum, so we need to remove any mentions of it.

This PR

  • Removes any mention of Replit
    • Leaves IRB recommendation in place wherever it is already mentioned
  • Replaces specific Replit suggestions with a more generic suggestion to just use a REPL
  • Removes instructions for submitting a Replit live demo included in the Basic Informational Site project (from Introduction to NodeJS course)
  • Replaces Replit suggestion with Codepen suggestion instead (in Join the Odin Community lesson)
    • Codepen is frequently used/recommended in the course and Discord already, so it makes more sense to suggest Codepen anyways

Issue

Related to https://github.com/TheOdinProject/curriculum/issues/29054

Additional Information

Pull Request Requirements

  • [x] I have thoroughly read and understand The Odin Project curriculum contributing guide
  • [x] The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • [x] The Because section summarizes the reason for this PR
  • [x] The This PR section has a bullet point list describing the changes in this PR
  • [x] If this PR addresses an open issue, it is linked in the Issue section
  • [x] If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • [x] If any lesson files are included in this PR, they follow the Layout Style Guide

Eduardo06sp avatar Dec 11 '24 09:12 Eduardo06sp

The linter errors don't seem to be related to the specific changes I made.

I absolutely don't mind fixing them if needed. However, I don't want to do that without permission.

Eduardo06sp avatar Dec 11 '24 09:12 Eduardo06sp

I do think the linter errors should be fixed in a separate PR, and it shouldn't be you who has to fix it @Eduardo06sp. I'd be curious to know how they make their way in this far, how they're getting approved.

zachmmeyer avatar Jan 06 '25 04:01 zachmmeyer

The Node basic info project hasn't been touched for a while but will be when the relevant milestone is worked on in the Node revamp. Some of the other lint errors are due to "relatively" newer lint rules addressing stuff that's always been in the style guide but never caught due to no rule. Stuff like not having questions for learning overview items or no nested lists in the AR section, and IIRC a fair few Ruby lessons still have this. There are some script-fixable lint errors like line break stuff that can easily be addressed now.

mao-sz avatar Jan 07 '25 15:01 mao-sz

@JoshDevHub I just cleaned some of the auto-correctable ones up. In the Basic Informational Site project, I had to convert the HTML filenames to inline code manually. Otherwise, the linter was changing anything with .html to .HTML.

The rest were just adding blank lines, or using lazy numbering for one of the numbered lists.

Honestly, there aren't that many errors left, but I will leave them alone as you requested.

Eduardo06sp avatar Jan 14 '25 07:01 Eduardo06sp

Are you happy for this one to be merged @JoshDevHub? most of the remaining linting errors seem to be related to learning outcomes that require a rewrite - probably best left to a separate PR?

KevinMulhern avatar May 04 '25 15:05 KevinMulhern

I made the following changes in join_the_odin_community.md file:

  • Clarified that user should use an "appropriate online REPL", with CodePen being an example after that

Throughout Ruby lessons and projects where REPL is mentioned:

  • Clarified that user should use an "appropriate" REPL
  • Generally speaking, I only made this change only where REPL is first mentioned on a given lesson/project, not subsequent mentions
  • Re-ordered at least one sentence so that irb is recommended before "any other REPL", for the sake of consistency
    • e.g. "try irb or any other REPL" instead of "try using any REPL or irb"

In basic_data_types.md and debugging.md:

  • I moved the link explaining what a REPL is to basic data types, because I believe that is where REPLs are first mentioned

I extended the change to other files because it seems that, as a beginner, seeing "use an appropriate REPL" will make you realize that you should search online for a Ruby-specific REPL.

I also moved the REPL explanation to the lesson where I believe it is first mentioned. It made more sense to give the introductory explanation where REPL is first mentioned, instead of much later in that section.

I will certainly revert those commits if anyone disagrees!

Eduardo06sp avatar May 27 '25 20:05 Eduardo06sp