JavaScript: clarification for Async. Code recommendation to read article
Checks
- [X] This is not a duplicate of an existing issue (please have a look through our open issues list to make sure)
- [X] I have thoroughly read and understand The Odin Project Contributing Guide
- [ ] Would you like to work on this issue?
Describe your suggestion
In the lesson on asynchronous code, the following instruction is given: Take a moment to skim through this article on callbacks before moving on
I think this should be rephrased to: Take a moment to skim through this article's explanation of callbacks before moving on
The reason I am suggesting this re-write is because the article is actually a wide-ranging one (it is not only talking about callbacks) and it is not immediately clear when we are sent there that we're supposed to stop reading at the end of the callback section (or so I assume now!) as there's an event section immediately after the callback section which seemed relevant to me for example (as it is presented as an alternative to callbacks), so I kept reading until I finally reached Streams and then I started to suspect I'd read a bit too far at that point).
If I'm correct that the intention is only read the section of the article entitled "Callbacks", then this slight re-wording may make that clearer to the audience. Thanks for your help.
Path
Node / JS
Lesson Url
https://www.theodinproject.com/lessons/node-path-javascript-asynchronous-code
(Optional) Discord Name
No response
(Optional) Additional Comments
No response
Amending the link text label to article section on callbacks should be sufficient, since the link is specifically to the callbacks section of the whole thing. So if "article" alone was the source of confusion despite that, "article section" should be clearer while retaining an accessible link text label.
Hey @hbar1st - I noticed you didn't check that you wanted to work on this issue. Are you open to me working on this and submitting the PR? š
@MaoShizhong - I hope I'm not overstepping by asking this!
I'm no longer a maintainer so I'm not the one who can assign people anymore. If the author hasn't requested assignment themselves, then you're welcome to do so, just don't actually open a PR unless you've been assigned by a maintainer.
@RonnocNiksab have at it, thanks for volunteering and thank you @hbar1st for raising the issue!
This issue is stale because it has had no activity for the last 30 days.
Hey @RonnocNiksab, just checking in - are you still working on this, or would you like us to give someone else a shot at it?
Hi @KevinMulhern - someone else can take a shot. I apologize for the delay in reply, my notifications settings were not what I expected.
Hi @KevinMulhern! Iād be happy to work on this issue ā I think it would be a great first PR for me to contribute. Please let me know if I can go ahead and take it. Thanks!
Sure thing @mozartdd, I've assigned it to you!