curriculum icon indicating copy to clipboard operation
curriculum copied to clipboard

Foundations: Object Basics: Bad Filter-Map-Reduce Visual

Open ruben-vl opened this issue 1 year ago • 6 comments

Checks

Describe your suggestion

In the Object Basics lesson of the Foundations course, there is a visual for the filter/map/reduce array methods.

This image has some problems:

  • image resolution is quite bad
  • image quality is terrible (e.g. no centering, non-consistent arrows, ...)
  • the referenced url is cropped, making the original hard to find (I found a subset of the image here; i suspect someone hand-made the filter part (first arrow is obviously copied, with the shading of the cut bread image visible, and the font on filter being different)

Possible solutions:

  1. remake the diagram with some better pictures, proper centering, and a higher quality export (+ reference to the 'inspiration image' ofcourse)
  2. replace with a better visual for these three methods (+ reference)
  3. remove the image and provide a textual summary

I think option 2 is best, with option 3 as fallback, but I would love to hear your suggestions! I also wouldn't mind working on this, but if someone else is eager to work on a simple issue, by all means go ahead! :)

Path

Foundations

Lesson Url

https://www.theodinproject.com/lessons/foundations-object-basics

(Optional) Discord Name

ruben-vl

(Optional) Additional Comments

No response

ruben-vl avatar Aug 24 '24 10:08 ruben-vl

Wouldn't be opposed to a higher resolution and neater equivalent, whether that's an alternative image we can attribute or a custom made one.

If you'd like to work on this, I can assign it to you. Handling images in lessons is a 2-PR process - one to replace the image file, a second to replace the CDN link for the image in the appropriate lesson, and any other alt text etc.

mao-sz avatar Aug 25 '24 16:08 mao-sz

If OP doesn't have bandwidth rn, I can take this issue up

mathdebate09 avatar Aug 26 '24 14:08 mathdebate09

If OP doesn't have bandwidth rn, I can take this issue up

Go ahead, I don't have much time for it atm.

ruben-vl avatar Aug 26 '24 15:08 ruben-vl

Cheers both. Assigned, @mathdebate09

mao-sz avatar Aug 26 '24 15:08 mao-sz

objects

Res: 1780 x 1200

Made this using figma, let me know if any changes would be needed, or else i can submit a pr

Edit: Figma Link

mathdebate09 avatar Aug 26 '24 16:08 mathdebate09

This issue is stale because it has had no activity for the last 30 days.

github-actions[bot] avatar Sep 26 '24 02:09 github-actions[bot]