curriculum icon indicating copy to clipboard operation
curriculum copied to clipboard

Broken link in the Assignment section(number 2)

Open Bright-Anyawe opened this issue 1 year ago • 5 comments

Checks

Describe your suggestion

The second link(number 2) in the assignment section does not provide any information relating to the topic at hand

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/javascript-working-with-remotes

(Optional) Discord Name

Bryt55

(Optional) Additional Comments

No response

Bright-Anyawe avatar Aug 20 '24 10:08 Bright-Anyawe

I have checked it. It seems to be working fine, it redirects you to the introduction of the article, you should just press "Let's get started, shall we?"

Bidrift avatar Aug 24 '24 10:08 Bidrift

While the link isn't broken (as explained above), I think we can make the assignment step clearer as to exactly what we want people to do.

Acceptance criteria

  • [ ] Assignment step 2's link text is changed to "Think Like (a) Git"
  • [ ] The href for the 2nd assignment's link is changed to https://think-like-a-git.net/sections/about-this-site.html
  • [ ] The assignment step itself is reworded to be clearer that the user should read the whole thing e.g. reword to Read the entirety of [Think Like (a) Git](...).

Please comment below if you'd like to be assigned to this issue. Please do not open a PR unless you have been assigned by a maintainer.

mao-sz avatar Sep 04 '24 18:09 mao-sz

i would like to work on this issue!

eGOist-sys avatar Sep 04 '24 19:09 eGOist-sys

All yours @eGOist-sys

mao-sz avatar Sep 04 '24 20:09 mao-sz

This issue is stale because it has had no activity for the last 30 days.

github-actions[bot] avatar Oct 05 '24 02:10 github-actions[bot]

Hi @MaoShizhong , is anyone actively working on this? If not, I'd like to take it on. (Sorry for the ping)

blue0206 avatar Feb 17 '25 03:02 blue0206

I'm no longer an active maintainer so won't be able to do any swapsies, but I'll try and get a maintainer to do handle this :)

mao-sz avatar Feb 17 '25 07:02 mao-sz

Thanks for the quick response and for passing this along!

blue0206 avatar Feb 17 '25 07:02 blue0206

Hi @MaoShizhong , is anyone actively working on this? If not, I'd like to take it on. (Sorry for the ping)

All yours @blue0206. Please reach out here if you run into any problems!

JustWaveThings avatar Feb 17 '25 17:02 JustWaveThings

Thanks! I'll take it from here. I'll let you know if I encounter any issues.

blue0206 avatar Feb 17 '25 17:02 blue0206

@JustWaveThings I have made the fixes and created a PR #29427 I've followed along the acceptance criteria. Please let me know if any adjustments are needed. Thanks!

blue0206 avatar Feb 17 '25 19:02 blue0206