curriculum icon indicating copy to clipboard operation
curriculum copied to clipboard

Objects and Object Constructors: setPrototypeOf() not explained properly

Open mahmoudmerghani opened this issue 1 year ago • 10 comments

Checks

Describe your suggestion

The lesson doesn't explain setPrototypeOf() thoroughly, it doesn't make it clear that Object.setPrototypeOf(Player.prototype, Person.prototype); is like Player.prototype.__proto__ = Person.prototype and the explanation of why Player.prototype = Person.prototype doesn't work is not clear

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/node-path-javascript-objects-and-object-constructors

(Optional) Discord Name

No response

(Optional) Additional Comments

No response

mahmoudmerghani avatar Aug 14 '24 15:08 mahmoudmerghani

Thanks @mahmoudmerghani, do you have any suggestions on how we can make it clearer?

KevinMulhern avatar Aug 18 '24 09:08 KevinMulhern

diagrams that show the object hierarchy would be helpful. and clarifying the distinction between an instance object prototype which is the constructor prototype property and the prototype of that same prototype. also the difference between the internal prototype of a constructor [[prototype]] and the property prototype.

mahmoudmerghani avatar Aug 18 '24 15:08 mahmoudmerghani

This issue is stale because it has had no activity for the last 30 days.

github-actions[bot] avatar Sep 18 '24 01:09 github-actions[bot]

I'm happy to open this up to anyone who thinks they have a soution for it

CouchofTomato avatar Sep 18 '24 15:09 CouchofTomato

This issue is stale because it has had no activity for the last 30 days.

github-actions[bot] avatar Oct 19 '24 02:10 github-actions[bot]

@CouchofTomato I can take this up if no one's assigned

dekr1sh avatar Dec 27 '24 14:12 dekr1sh

This issue is stale because it has had no activity for the last 30 days.

github-actions[bot] avatar Jan 27 '25 02:01 github-actions[bot]

Hey @dekr1sh

Apologies. I've had a few things on. Do you still want to work on this?

CouchofTomato avatar Feb 06 '25 18:02 CouchofTomato

@CouchofTomato I'd be happy to :)

dekr1sh avatar Feb 09 '25 10:02 dekr1sh

@dekr1sh I've assigned it to you. Thanks :)

CouchofTomato avatar Feb 11 '25 19:02 CouchofTomato