curriculum icon indicating copy to clipboard operation
curriculum copied to clipboard

Update bullet 4 instructions in git_basics.md

Open newtreenoh opened this issue 1 year ago • 3 comments

Edited bullet 4 in Use the Git workflow for clarity

Because

The instructions in the bullet 4 were a little confusing.

This PR

Edited bullet 4 in Use the Git workflow for clarity...for clarity. Lol.

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • [x] I have thoroughly read and understand The Odin Project curriculum contributing guide
  • [x] The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • [x] The Because section summarizes the reason for this PR
  • [x] The This PR section has a bullet point list describing the changes in this PR
  • [ ] If this PR addresses an open issue, it is linked in the Issue section
  • [ ] If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • [ ] If any lesson files are included in this PR, they follow the Layout Style Guide

newtreenoh avatar Aug 02 '24 09:08 newtreenoh

Hi @zachmmeyer thanks for the review. The suggestions have been implemented. Please could you let me know if anything else required? Thanks!

newtreenoh avatar Aug 03 '24 16:08 newtreenoh

@newtreenoh The guidelines suggest the title should be something more like Git Basics: Add clarity to instructions. I want to make sure we get it right before this gets locked in, as this is your first.

The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text The intention should be that you do what's in the template and check it off as it's completed, including checking your work with the markdown tool.

zachmmeyer avatar Aug 03 '24 16:08 zachmmeyer

@newtreenoh checking in if you're good to make the changes I requested

zachmmeyer avatar Aug 09 '24 02:08 zachmmeyer

Closing due to no response. This pull request can be reopened in the future if the changes can be made.

zachmmeyer avatar Sep 01 '24 22:09 zachmmeyer