TheOdinProject
Rails Pathway: Provide descriptive link text (multiple assignees)
Links in our lessons should be sufficiently descriptive to improve accessibility. As per the layout style guide, link text should both concisely describe its purpose (or where the link will redirect a user), and must not include the words this nor here.
Guidance
- Comment on this issue to let us know you'd like to get a section assigned to you. You can also ask for a specific one.
- Please wait until you are assigned by a maintainer before starting to work on this issue to avoid multiple people working on the same lessons.
- When you have been assigned a section, please refer to the suggested link text changes spreadsheet for instructions on what changes need to be made for your assigned lesson(s).
- For most of these, you should just be able to copy and paste the suggested text to replace the original text shown in the spreadsheet (which may be more than just the link itself). Any additional steps/clarifications will be noted by the appropriate link(s).
- You are welcome to use a different wording from a given suggestion if you find a better one. If you do, you must ensure the link text is consistent if there are multiple instances of the same href in the same lesson.
- Line numbers for the files should be mostly accurate. It's possible that I missed an unrelated PR for a file and some numbers are a little off, but you can always search the file for the relevant text as necessary.
- You are not required to fix any unrelated, preexisting linting errors such as list styles/indentation. Existing linting errors may cause certain tests to fail when you open a PR. You can ignore this and a maintainer will let you know if further action is required.
- Make sure to read the general contributing guide as well as the curriculum repo contributing guide before starting your first contribution.
- Please add the following to your PR in the Issues section:
Related to #28290. Since this issue is divided into sections, individual PRs should NOT INCLUDE thecloseskeyword next to an issue number.
Progress and assignees
Ruby
- [x] @SumonGFC How This Course Will Work && Installing Ruby && Basic Data Types
- [x] @CJKbarts Methods
- [ ] @TheSeagullDev Debugging && Basic Enumerable Methods && Predicate Enumerable Methods
- [x] @davidumoru Nested Collections && Project: Caesar Cipher
- [ ] Project: Bubble Sort && Object Oriented Programming: UNASSIGNED
- [ ] Project: Tic Tac Toe && Files and Serialization && Pattern Matching: UNASSIGNED
- [ ] Blocks && Project: Custom Enumerables: UNASSIGNED
- [x] @Grayvox A Very Brief Intro to CS && Recursive Methods && Project: Recursion
- [ ] Space Complexity && Project: Binary Search Trees && Project: Knights Travails: UNASSIGNED
- [ ] Common Data Structures && HashMap Data Structure: UNASSIGNED
- [ ] Test Driven Development && Project: Connect Four && Project: Ruby Final Project: UNASSIGNED
- [ ] Introduction to RSpec && Conclusion: UNASSIGNED
Databases
- [x] @AhmedTheGreatest Databases && Project: SQL Zoo
Ruby on Rails
- [ ] Project: Installing Rails && A Railsy Web Refresher: UNASSIGNED
- [ ] Routing && Project: Blog App && Deployment: UNASSIGNED
- [ ] Form Basics && Sessions Cookies and Authentication && Project: Members Only!: UNASSIGNED
- [ ] Installing PostgreSQL && Project: Private Events: UNASSIGNED
- [ ] Active Record Queries && Active Record Callbacks: UNASSIGNED
- [ ] Advanced Forms && Project: Flight Booker: UNASSIGNED
- [ ] APIs and Building Your Own: UNASSIGNED
- [ ] @SeanAverS Working with External APIs
- [ ] Project: Kittens API && Project: Flickr API && JS Bundling: UNASSIGNED
- [ ] Turbo && Stimulus && Mailers && Project: Sending Confirmation Emails: UNASSIGNED
- [ ] Advanced Topics: UNASSIGNED
- [x] @mathdebate09 Websockets and Action Cable && Basic Messaging App (actioncable_lesson.md) && Project: Rails Final Project && Conclusion
Hi @MaoShizhong
I am interested on working on this and would like be assigned the Working with External APIS section please 😄
Hey Mao, can you assign me the section on Websockets and Action Cable && Basic Messaging App (actioncable_lesson.md) && Project: Rails Final Project && Conclusion to me?
Edit: I just went through the provided spreadsheet, though I wasn't able to find out any guide for lessons, Websockets and Action Cable, Basic Messaging App and Project: Rails Final Project, incase it's under progress/already done, you can assign me any other topics as well :)
@mathdebate09 They're in the Ruby on Rails sheet. Just checked it and can see them there. Can you check again and see if they're there?
@MaoShizhong Noob question: Single commit preferred? or one commit for each lesson?
@MaoShizhong Noob question: Single commit preferred? or one commit for each lesson?
Ultimately, either is fine. Personally, if I was working on this myself, I'd make separate commits for each lesson because that's what feels most intuitive and maintainable to me.
I'm interested in contributing to this. Could you please assign me to any of the ruby sections except the last 2?
I can do another one if it is fine for us to do more than one.
Appreciate the enthusiasm. As with previous similar issues, to encourage wider participation, we're limiting to one per person for now. These changes aren't urgent, so we're not in a rush to get them done as soon as possible.
@AhmedTheGreatest assigned you to Databases && Project: SQL Zoo
@TheSeagullDev assigned you to Debugging && Basic Enumerable Methods && Predicate Enumerable Methods
Hey @MaoShizhong ! I'd love to help with the A Very Brief Intro to CS && Recursive Methods && Project: Recursion sections if that's alright.
@Grayvox Assigned you to those lessons.
@davidumoru Assigned you to Nested Collections && Project: Caesar Cipher
@MaoShizhong could you please review my pull request?
I don't know if there's something I'm supposed to do...
@MaoShizhong could you please review my pull request?
I don't know if there's something I'm supposed to do...
@CJKbarts We're all volunteers here (including you!) where we all have our own lives and families etc. to get to. We will get to reviewing PRs when we are able to, even if that does take a little time, especially when a PR does not contain an urgent change. It may not even be me - anyone on the team may review a PR if appropriate.
Coincidentally, I did just finish reviewing your PR, but even if I hadn't, I or another maintainer would get to it eventually, so please be patient.
I understand that...I'm sorry for rushing you.
When I read the documentation for pull requests it said to to request for a review from one of the reviewers of the PR but I didn't have you on there so I didn't know if you weren't able to do it because I hadn't added you on there...and I didn't know how.
I'm sorry once again.
I reread what I typed and I dunno if it makes sense...buh long and short is that I was confused
It won't happen again...thank you for your patience
I reread what I typed and I dunno if it makes sense...buh long and short is that I was confused
It won't happen again...thank you for your patience
If you have any uncertainties about your PR, you can always comment on the PR with whatever questions and when a maintainer has time to review it, they can address your concerns :)
@MaoShizhong happy to help with a section (or more) - I have no preference. Thank you :)
