curriculum icon indicating copy to clipboard operation
curriculum copied to clipboard

<React>: <Type Checking with Prop Types additional resources>

Open Dillonpw opened this issue 1 year ago • 3 comments

Checks

Describe your suggestion

The additional resources section is currently empty for this lesson, I'd like to suggest a few useful links that will provide extra information for those curious about adopting TypeScript for their later projects.

"If you are interested in using TypeScript in your upcoming projects and want to learn more:"

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/node-path-react-new-type-checking-with-proptypes

(Optional) Discord Name

No response

(Optional) Additional Comments

No response

Dillonpw avatar Jan 31 '24 22:01 Dillonpw

@TheOdinProject/javascript

Anyone have an opinion on this?

CouchofTomato avatar Feb 01 '24 14:02 CouchofTomato

I'm happy to make the pull request to add the information if there are no objections.

Dillonpw avatar Feb 05 '24 20:02 Dillonpw

So this lesson has the what about typescript section that does offer some warnings about diving into it, and that we don't recommend looking into it right now.

I do think that we shouldn't link to the TypeScript docs in that section, especially right before an assignment and when we're telling users not to look into it right now (I feel like providing the docs can just lead to users going down a rabbit hole).

Kind of wondering whether we should even keep this "What about TS" section, or just move its contents to additional resources (with some verbiage tweaking). In its current spot I think it really only benefits users who have heard of TS, but maybe aren't using it/haven't used it before. Users who have heard of and used it before may already be using it/decide to use it anyway, and users who haven't heard of TS wouldn't be using it. Curious what @01zulfi thinks.

thatblindgeye avatar Feb 17 '24 16:02 thatblindgeye

Not Xari but I'm of the opinion that we leave the proptypes lesson as is i.e. not add typescript resources in the AR section, nor move the What about TypeScript section.

It's agree that it'll unlikely cause anyone who's already chosen to use TS independently to stop using TS for the rest of the course (although I actually did that not too long into the Node section). However, I think it still has benefits of bringing attention to why TS isn't included in the curriculum for now and also reassuring anyone who may be considering it around this point. The placement in this particular lesson is topical and keeping it in the main lesson contents both (IMHO) enhances visibility and reinforces the bullet for assignment step 1.

MaoShizhong avatar Mar 15 '24 09:03 MaoShizhong

This issue is stale because it has had no activity for the last 30 days.

github-actions[bot] avatar Apr 15 '24 02:04 github-actions[bot]

@MaoShizhong at the very least what do you think about removing the link to the Typescript docs? Or updating the link to redirect to the wiki page on TS to serve more as a "definition link"?

thatblindgeye avatar Apr 15 '24 13:04 thatblindgeye

@thatblindgeye I'd be good with just dropping the TypeScript link and just keeping the text as straight text.

MaoShizhong avatar Apr 15 '24 13:04 MaoShizhong

This issue is stale because it has had no activity for the last 30 days.

github-actions[bot] avatar May 16 '24 01:05 github-actions[bot]

@Dillonpw would you still be interested in working on this based on the above comments?

thatblindgeye avatar May 16 '24 11:05 thatblindgeye

@thatblindgeye Sure! I'll submit a pull with the suggestions in mind as soon as possible.

Dillonpw avatar May 16 '24 19:05 Dillonpw