curriculum icon indicating copy to clipboard operation
curriculum copied to clipboard

Update link in assignment

Open odilson-dev opened this issue 1 year ago • 9 comments

Because

This PR is about updating the link of Ressources in the asiignment section, it's improve the experience of students by guiding them directly to the section we want them to read.

This PR

  • Update the link to the right section

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • [x] I have thoroughly read and understand The Odin Project Contributing Guide
  • [x] The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • [x] The Because section summarizes the reason for this PR
  • [x] The This PR section has a bullet point list describing the changes in this PR
  • [x] If this PR addresses an open issue, it is linked in the Issue section
  • [x] If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • [x] If any lesson files are included in this PR, they follow the Layout Style Guide

odilson-dev avatar Dec 20 '23 01:12 odilson-dev

You also have some merge conflicts you'll need to address before we can merge this.

CouchofTomato avatar Dec 20 '23 14:12 CouchofTomato

Hi, i resolved merge conflicts, please let me know if any changes are requirded before merge.

odilson-dev avatar Dec 21 '23 01:12 odilson-dev

Hi, i resolved merge conflicts, please let me know if any changes are requirded before merge.

It looks like merging in main may have reset one of the lines because I don't think it should be 21

image

CouchofTomato avatar Jan 05 '24 12:01 CouchofTomato

Hi, i resolved merge conflicts, please let me know if any changes are requirded before merge.

It looks like merging in main may have reset one of the lines because I don't think it should be 21

image

Just fixed that. Thanks

odilson-dev avatar Jan 05 '24 13:01 odilson-dev

Hey @odilsoncode

Just wondering if you were still interested in finishing this PR up?

CouchofTomato avatar Feb 06 '24 14:02 CouchofTomato

Hi @CouchofTomato I thought this PR was already completed and merged but it seems that it is not. Please, let me know what other changes i've to make again so we can finish up.

odilson-dev avatar Feb 07 '24 16:02 odilson-dev

Hey @odilsoncode

There are some merge conflicts. We can't merge until these are resolved.

CouchofTomato avatar Feb 16 '24 14:02 CouchofTomato

Hmmm... hi @CouchofTomato , i'm currently facing a bunch of errors on this PR, and i'm not sure where they come from. Any assistance please?

odilson-dev avatar Feb 16 '24 15:02 odilson-dev

@odilsoncode You can ignore those errors, they're just from our new linter that is helping us flag things to help lessons comply with our layout style guide.

@CouchofTomato do the changes to the PR look good to you?

thatblindgeye avatar Feb 23 '24 16:02 thatblindgeye

Is there stuff that's meant to be changed here? Currently the diff only shows a single change that's removing trailing whitespace, but otherwise doesn't seem to show any changes from the current lesson.

MaoShizhong avatar Jul 15 '24 19:07 MaoShizhong

Yeah it was supposed to update the chapter links for the exercises because the rails guide changed them. I think I'll have to just edit it at some point.

CouchofTomato avatar Jul 16 '24 14:07 CouchofTomato

@CouchofTomato

~~Interesting that this PR's latest state doesn't have those href changes (edit: ah, the last merge conflict resolution wiped the changes).~~

~~Currently, we have #28421 in review as part of the accessible link text epic for the Rails pathway, and that PR makes changes to the links in the Active Record Queries lesson. It doesn't change any of the hrefs, only the link text. Do you think it would be sensible to close this PR, and request href and section number changes for the relevant links in that PR instead?~~

~~From what I've gathered, the href ending in #group should be updated to #grouping, and some of the steps' section numbers need to be adjusted.~~

MaoShizhong avatar Jul 16 '24 15:07 MaoShizhong

@CouchofTomato Just an update that the #group URL has been fixed to #grouping in #28421.

Regarding the required reading sections, could this PR be closed then a new issue opened up for contribution to handle that?

MaoShizhong avatar Jul 19 '24 20:07 MaoShizhong

@MaoShizhong Yeah I'm ok with that

CouchofTomato avatar Jul 26 '24 13:07 CouchofTomato

@CouchofTomato Then I'll leave the new issue with you, as you'll know best what needs to be changed.

MaoShizhong avatar Jul 26 '24 13:07 MaoShizhong