yadm icon indicating copy to clipboard operation
yadm copied to clipboard

post_bootstrap hook is not executed

Open dennislapchenko opened this issue 3 years ago • 4 comments

Describe the bug

Hooks with post_ and <command> should be invoked after successful commands execution. post_boostrap hook is not executed after yadm bootstrap

To reproduce

HOOKPATH=$HOME/.config/yadm/hooks/post_bootstrap
echo "echo test bs log" > $HOOKPATH && chmod a+x $HOOKPATH
yadm bootstrap

Alternatively a:

HOOKPATH=$HOME/.config/yadm/hooks/post_pull
echo "echo test pull log" > $HOOKPATH && chmod a+x $HOOKPATH
yadm pull

Outputs:

Already up to date.
test pull log

Expected behavior

Given correct hooks location is created, with properly named file and permissions: post hook for yadm bootstrap should be executed.

Environment

  • darwin arm64
  • yadm 3.1.1
  • git version 2.33.0

dennislapchenko avatar Oct 10 '21 10:10 dennislapchenko

For me, pre_commit does not seem to be working, either.

shadowrylander avatar Nov 02 '21 03:11 shadowrylander

@dennislapchenko - This does seem to be a bug, bootstrap is run via an exec (the commands becomes the bootstrap command). So no post_hook is ever processed.

@shadowrylander - pre_commit should work without any issue. Is your pre_commit file executable?

TheLocehiliosan avatar Nov 29 '21 20:11 TheLocehiliosan

I am currently not a position to check, but I'll let you know once my setup is finalized!

shadowrylander avatar Nov 30 '21 01:11 shadowrylander

This issue has been labeled as stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jan 29 '22 02:01 github-actions[bot]