GooglePhotosTakeoutHelper icon indicating copy to clipboard operation
GooglePhotosTakeoutHelper copied to clipboard

Add iOS Live Photo support and another format for guess_extractor

Open BobTheSoftwareDeveloper opened this issue 1 year ago • 16 comments

First of all, great tool! It has made my process of organising the Google Photos export so much nicer for when I upload the backup to S3.

I have tested the changes locally and it was able to add the EXIF date data to the video files successfully.

BobTheSoftwareDeveloper avatar Jul 16 '23 12:07 BobTheSoftwareDeveloper

Nice! Tho i will need to think more about it, how we should handle it etc, so give me some time to merge it...

TheLastGimbus avatar Aug 13 '23 22:08 TheLastGimbus

So, for now, i'm leaving this waiting for further advancements in metioned discussion...

But, for anyway that wants this NOW, here are nightlies :>

https://github.com/TheLastGimbus/GooglePhotosTakeoutHelper/actions/runs/6280579316

TheLastGimbus avatar Sep 23 '23 00:09 TheLastGimbus

Hey @TheLastGimbus @BobTheSoftwareDeveloper

Thanks for putting this PR together, I just tested the nightly build and wow! What a difference!

Using the latest version (v3.4.3) gpth shows loads of errors like:

Can't get date on /Volumes/Macintosh HD/Users/user/Downloads/Takeout/Google Photos/.../IMG_8354.MP4

And the summary output shows gpth failing to find metadata for many files:

Couldn't find date for 1997 photos/videos :/

Whereas, using the nightly build with this PR included:

Finding duplicates...
Guessing dates from files : █████████████████....................... 5285/12187  
Can't get date on /Volumes/Macintosh HD/Users/user/Downloads/Takeout/Google Photos/Photos from 2019/moments_09_19_8_20_51 pm.MP4
Guessing dates from files : ███████████████████████████████████████. 12186/12187  
Finding albums (this may take some time, dont worry :) ...
Moving photos to output folder : ████████████████████████████████████████ 12187/12187  
========================================
DONE! FREEEEEDOOOOM!!!
Skipped 3 duplicates
Couldn't find date for 1 photos/videos :/

Only 1 file failed 👍🏻 😃

dbrennand avatar Sep 25 '23 14:09 dbrennand

Only 1 file failed

We're leaving not even one! @dbrennand Could you try to find other files related to this one (og photo and json)?

TheLastGimbus avatar Sep 25 '23 15:09 TheLastGimbus

Only 1 file failed

We're leaving not even one! @dbrennand Could you try to find other files related to this one (og photo and json)?

I can have a look, what am I looking for exactly in the JSON?

dbrennand avatar Sep 25 '23 15:09 dbrennand

You're just looking for the json, and it's filename 👍👍

I just want to figure out why gpth didn't find it - it does so by filenames purely

TheLastGimbus avatar Sep 25 '23 21:09 TheLastGimbus

You're just looking for the json, and it's filename 👍👍

I just want to figure out why gpth didn't find it - it does so by filenames purely

@TheLastGimbus - I'm not sure why it failed... 🤔 So for this live photo, the three files are named:

  • moments_09_19_8_20_51 pm.JPG
  • moments_09_19_8_20_51 pm.MP4
  • moments_09_19_8_20_51 pm.JPG.json

title value in the JSON is:

{
  "title": "moments_09_19_8_20_51 pm.JPG",
}

dbrennand avatar Sep 26 '23 21:09 dbrennand

can you please look into it?

zxsleebu avatar Dec 06 '23 19:12 zxsleebu

@zxsleebu I'm gonna be honest - right now, no.

And I can't really point when, but like a month from now at least. If you need your takeout with this, use @BobTheSoftwareDeveloper fork - nightlies are still here: https://github.com/TheLastGimbus/GooglePhotosTakeoutHelper/actions/runs/6280579316

It will even help to test it if you used it. I just don't have the time right now to make 10000% sure it all works (and potentially add all cool features above) and list it on the official repo

TheLastGimbus avatar Dec 07 '23 08:12 TheLastGimbus

can you please re-build https://github.com/TheLastGimbus/GooglePhotosTakeoutHelper/actions/runs/6280579316

Edit: nvm I forked it and ran it myself. I can confirm I went from 3.5k "Can't get date on...." to only 40 - everything else worked fine. Thanks

Alkanov avatar Dec 25 '23 20:12 Alkanov

https://github.com/TheLastGimbus/GooglePhotosTakeoutHelper/actions/runs/7358237528

TheLastGimbus avatar Dec 29 '23 16:12 TheLastGimbus

https://github.com/TheLastGimbus/GooglePhotosTakeoutHelper/actions/runs/7358237528

I have met the same problem. Latest release is on Sep 23, 2023. The rebuild has expired. Can we have a new release?

pzh200707 avatar Apr 01 '24 08:04 pzh200707

Sure guys

https://github.com/TheLastGimbus/GooglePhotosTakeoutHelper/actions/runs/8510134630

TheLastGimbus avatar Apr 01 '24 15:04 TheLastGimbus

Any chance of being able to add RAW file support? Seems like some .dng and .cr2 files I had weren't transferred over.

Not the worst, since it seems like the EXIF data has been kept intact, but adds another step to the process.

Edit: Seems like .cr2 files were transferred over fine. What caused me issues were ~3mb "CR2" files that were actually jpgs, but labeled CR2 thanks to Google Photos. Renaming the files as JPG brought back all of their EXIF data and I could organize accordingly.

mguzman011 avatar May 19 '24 21:05 mguzman011

Seems like some .dng and .cr2 files I had weren't transferred over.

I will look at it when i will take care of this project some day :rainbow:

TheLastGimbus avatar May 20 '24 11:05 TheLastGimbus

Unfortunately for me all the Live Photos (MP4'S) went into a folder named "date-unknown"

Date-unknown folder has files such as:

  • IMG_0416.MP4
  • FullSizeRender(48).MP4
  • 3266b48c2d6747d685fae28c5fb36f48.mov

fredsco avatar Jul 26 '24 21:07 fredsco