MiNode icon indicating copy to clipboard operation
MiNode copied to clipboard

Use SQLite instead of pickle for object handling

Open viralpoetry opened this issue 7 years ago • 2 comments

Krzysztof, Thanks for sharing your source code! It's clean and easy to read.

Not sure whether you are still working on it, but I think it should be better to use some database for the objects, so some future API can use it as well. Hence I have created this issue.

viralpoetry avatar Jun 03 '17 00:06 viralpoetry

Thank you for your interest!

I was planning on changing the method of object sorage but it is not a high priority issue. However I will definitely run some tests and do something about it at a later day.

TheKysek avatar Jun 04 '17 07:06 TheKysek

https://docs.python.org/3/library/pickle.html states

Warning

The pickle module is not secure against erroneous or maliciously constructed data. Never unpickle data received from an untrusted or unauthenticated source.

So I can understand why pickling is ill-advised 👍

Lvl4Sword avatar Jun 27 '17 01:06 Lvl4Sword