Jonas Jelten

Results 276 comments of Jonas Jelten

@MavethGH pling :) I interpret your last comment as you don't care about the copyright, and we can upstream the commits under our name, at least in case you don't...

thanks for your findings! first thing i wonder why it does work on our ci then. can you investigate, what target name is available for use? if there is an...

its true that we never tried using some python environment except the system one, since all the dependencies are usually packaged properly. but we can add support for that, why...

I think our rendering context extraction relies on X11, so we'd need a wayland path there to not use GLX, but whatever wayland provides us for that. This context then...

Sure, you can just submit an early pull request and get help in the chatroom :)

My recommendation would be to compare the similar-but-not-identical functions side by side (or copy them to files, and do `diff`, ...). Then you know what the differences are and copy...

moving the files to the system include path doesn't seem right. can you persuade your python to find them inside the build directory?

We now define `SDL_MAIN_HANDLED` (via #1407), so you can remove it from your patch. Is there a better way than copying files with `copycmd`? also your last hunk which changes...

Hah, somebody actually started working on the launcher :smile:, thank you very much! My first thought was: is pyqt5 the right library? I've read that the new upstream library is...

Ah, another idea: We do the main openage gui with qtquick and QML, so I think it would be beneficial if the launcher's UI design would also be done in...