KISS-multiplayer icon indicating copy to clipboard operation
KISS-multiplayer copied to clipboard

Downloads handled by bridge instead of mod

Open WhiteHusky opened this issue 2 years ago • 4 comments

  • [x] Bridge portion
  • [x] Mod portion

Instead of having the mod receive the bytes directly, have the bridge place the files itself for the mod to find and move around into place as needed.

Also miscellaneous refactors.

Security considerations: The mod can tell the bridge to place the files anywhere, but the bridge will not overwrite files nor try to delete file paths it didn't create.

WhiteHusky avatar Dec 24 '21 12:12 WhiteHusky

@AsciiJakob aka Verb reports the following numbers for a 233MB download on a 1Gbps connection. Game has the default limit framerate option (30FPS) when unfocused

Patch Condition Total Time
0.4.5 Focused 99s
0.4.5 Unfocused 499s-501s
PR Focused 28-31s
PR Unfocused 27-29s

WhiteHusky avatar Dec 27 '21 21:12 WhiteHusky

Fixed build issue; I had some changes that I'll wait for another PR for and selectively staged but kept back too much.

WhiteHusky avatar Dec 27 '21 21:12 WhiteHusky

This will fix #102 as an aside.

WhiteHusky avatar Dec 29 '21 06:12 WhiteHusky

May have forgotten to account for mods that updated. Additionally might need to change how mods are saved to avoid two mods of the same name from two servers clashing together (sha256 sum?)

WhiteHusky avatar Dec 31 '21 14:12 WhiteHusky