NaN notification counter when removing or adding back the service name

[Vaarlion]

Very low priority, but "FYI"

Steps to reproduce

1. create a service with some notification that aren't counted (single red dot)
2. edit it, and change the setting Show service name in Tab in any way

This append on a custom service, it is ok on gmail with a counting notification.

Expected behavior

the notification don't change

Actual behavior

the notification count bug, reloading the service fix it

ENVIRONMENT

Hamsket: v0.6.3 nightly

OS: Fedora 34

Arch: x64

Does this happen upstream: unknown

[vraravam]

@Vaarlion - do you mean to say that the NaN should be guarded against while displaying the unread counter/badge? Could you please provide the code/steps for me to reproduce?

[Vaarlion]

I have no real idea what part of the code is causing this as i didn't dig into it at all and my reading capability of web-based programing language is very limited. The issue isn't that NaN is showing, as i don't know it's use, but when.

This is happening when there is an unread notification that isn't counting, and i change the option Show service name in Tab

My random guess would be that when doing so, the label on top containing the notification icon and the title get regenerated, and the type of notification icon get switched from non-counting to counting.

That is just a random guess. Couldn't you use Steps to reproduce to reproduce it because it wasn't detailed enough ?

Have a good end of the years