TechnicSolder icon indicating copy to clipboard operation
TechnicSolder copied to clipboard

[Please Read] Soldier.CF Today

Open Kio-td opened this issue 2 years ago • 4 comments

Hi, friends! I was one of the folks who contributed a smaller bit of code into this system! I'm happy that I could help, but, I think it's time that we make it well aware. just in case you haven't noticed it yet, Solder.cf has gone stale.

Just to put my foot down here and now, I will personally not be maintaining Solder.cf any longer, as I have other projects that I will be maintaining. I believe the author has said that he will also be pursuing other projects, so please consider my message before you clone this repo. :)

For those who wish to continue working on it, have fun, and let me know on what you plan on doing! I'll be happy to give some feedback every now and again, but looking at this code from a fresh set of eyes, I really do suggest that people use either Zandercraft's Fork of Solder.cf (which has a few security upgrades - making password theft more difficult, and removing some of the invasive codes that were left by the previous creators) or they completely rework a new Soldering system.

Not to say that TheGameSpider's project was wonderful - it has been. I loved working on this palace from behind the scenes. But this script hasn't aged too well, being a being peice of spaghetti really hurts the eyes. and is heck and a half to debug.

Another couple of things I'd like to give as a quick mention,

  • The Fabric port I made is still just that, a little fabric port to s.cf, hastily thrown together and bound to s.cf with about 10 Liters of FlexGlue:tm:. If Copilot was available when I made that feature, it'd have deleted all my code and told me to start over. Please keep this in mind, if Fabric breaks the little patch-in job I made, I ain't going to fix it.

  • As much as I wished to add in Curseforge->Technic support, it seems like Overwolf/CurseForge are getting rid of 3rd party support with their undocumented APIs. Using these APIs eitherway prevent creators from getting money they deserve, and I'm not about to start building on-the-fly scrapers for PHP so people can have mods while simutaneously hitting Curseforge's monetization system (not to mention the potential for abuse that comes with it, and getting the people who use said system banned).

Edit: i've heard from a few sources that TGS has not only stopped working on SCF, but has gone completely AWOL, no longer responding to anyone. This just further reinforces my request that you switch to using Zandercraft's fork of this project.

\o Thanks, and bon voyage, my friends! Enjoy playing minecraft. You deserve it.

Kio-td avatar Sep 06 '22 04:09 Kio-td

Struggling to understand the point of this post.

Firstly, I don't understand the significance of you saying you are 'no longer maintaining' this project. As far as I'm aware, you involvement amounts to cleaning up the readme file two years ago?

Secondly, the fork you are recommending instead became itself stale two months before the main repo?

Pulz-TCP avatar Oct 20 '22 10:10 Pulz-TCP

Secondly, the fork you are recommending instead became itself stale two months before the main repo?

ZandercraftGames/TechnicSolder has a very important change to the auth system, some fixes that prevent RCE with regard to the config system while also fixing bugs that resulted in auth being unusable in certain cases, as well as (more recently) a bunch of code cleanup, support for Minecraft 1.16+ (by supporting newer Java versions), a fix to the white screen bug in PHP 8.x, and bug fixes pretty much everywhere.

Also Fabric support (thanks to @Kio-td ), although it's inaccessible right now due to some broken stuff. That will be resolved soon.

ZandercraftGames avatar Nov 01 '22 00:11 ZandercraftGames

ZandercraftGames/TechnicSolder has a very important change to the auth system, some fixes that prevent RCE with regard to the config system while also fixing bugs that resulted in auth being unusable in certain cases, as well as (more recently) a bunch of code cleanup, support for Minecraft 1.16+ (by supporting newer Java versions), a fix to the white screen bug in PHP 8.x, and bug fixes pretty much everywhere.

Also Fabric support (thanks to @Kio-td ), although it's inaccessible right now due to some broken stuff. That will be resolved soon.

I have had to use another account, as I have been restricted from this specific thread - which shows a level of immaturity that is extremely off-putting. Given that in this gaming niche, people with the same behaviour have acted maliciously on a few occasions.

As one of the biggest users of Solder, I will not show support for that kind of untrustworthy behaviour and would instead recommend users use the official Solder https://github.com/TechnicPack/TechnicSolder

You should clarify that the changes mentioned, were only made in the last day or two. Weeks after the discussion above. Over a year after the context.

sophon48 avatar Nov 01 '22 06:11 sophon48

I have had to use another account, as I have been restricted from this specific thread - which shows a level of immaturity that is extremely off-putting. Given that in this gaming niche, people with the same behaviour have acted maliciously on a few occasions.

You should clarify that the changes mentioned, were only made in the last day or two. Weeks after the discussion above. Over a year after the context.

I can't speak to your restriction on the thread as I had no involvement in that (and most certainly don't agree with that). I assume you are Pulz?

As for your comments about the changes; the fork has had PRs open for a long time to fix these issues. It has included custom fabric support for most of that time (until I broke it with upstream changes) and had some changes to auth (long before this - as were mentioned by Kio), although they've only now been completely and properly implemented. There have been bug fixes and other things on my branch that this repo has lacked since before the original post was made.

As for clarification of the timeframe of these changes, fair point. Some existed before, but it is only recently that many were added. I was simply speaking to the current situation (and why one might want to use my fork in the meantime).

I've been in contact with TGS to try to get the changes merged now that they are pretty much ready.

Regarding your recommendation of official Solder, I am inclined to agree (despite this making things much more convenient) as the number of security vulnerabilities this software has are pretty hard to estimate (code scanning estimates anywhere from 1k-2.6k - and most of the issues indicated with code scanning were resolved by my fork - about 4.5k). But at least we can try to fix the ones we know about, eh?

ZandercraftGames avatar Nov 01 '22 10:11 ZandercraftGames