MCprep icon indicating copy to clipboard operation
MCprep copied to clipboard

General model spawner issues, with short grass and grass block

Open zNightlord opened this issue 8 months ago • 3 comments

Previously #643 ~~This should deal with the short_grass problem by remap it back to its general grass name.~~ The grass block problem for now lowering the offset (it might be start to z fight when zoom out), guess temporally til there is a better proper solution *Maybe with numpy

Filtering out the blocks supposed not to be in the spawner

Change the material index mapping a little to handle things better no duplicates, on block with remaping #side for example logs, pillars image

Fix for cauldron, hopper, scraffolding. Adjust block uv that are animated have weirder texture ratios (lava, sculk, camp fire, sea lantern,...)

I am quite unsure about the preprocess_material(mat) changing the name which cause the problem so changed the name in the base json file.

Fix for #510 #653

Related #267

zNightlord avatar Apr 07 '25 19:04 zNightlord

Hopper and Cauldron and its variation blocks now have their dedicated uv data stored in resources json Fixing the stretched UV of spawned blocks related to #646

https://github.com/user-attachments/assets/dff67a1a-7ea4-4256-8e4c-71e3771c79e9

zNightlord avatar Apr 08 '25 09:04 zNightlord

Added override for "grass" since the get_vanilla_list map it to colormap/grass texture which causing issue This is the [colormap/grass texture] (https://github.com/InventivetalentDev/minecraft-assets/blob/1.21.5/assets/minecraft/textures/colormap/grass.png)

Edit: Numpy grass texture maybe it's better to save it for later.

zNightlord avatar Apr 25 '25 14:04 zNightlord

Add composter UV mentioned in #658

https://github.com/user-attachments/assets/50cfc9f8-3832-46fb-9663-ad77e1db5d08

zNightlord avatar May 17 '25 14:05 zNightlord

I'll also merge dev into this branch to handle the merge conflicts

StandingPadAnimations avatar Jun 22 '25 06:06 StandingPadAnimations

Merging this PR into dev

StandingPadAnimations avatar Jun 22 '25 06:06 StandingPadAnimations

Thanks for reviewing @StandingPadAnimations before I could get to it, was also going to grant my approval. Thanks @zNightlord for the continued contributions!

TheDuckCow avatar Jun 24 '25 04:06 TheDuckCow