MCprep icon indicating copy to clipboard operation
MCprep copied to clipboard

Selecting alpha faces is running wrong when your image resolution ratio is not 1:1

Open kken498 opened this issue 2 years ago • 4 comments

Did the issue happen after restarting Blender?

  • [X] Yes, the issue indeed continued after restarting Blender

Check known issues

  • [X] I have checked known issues, and my problem is different

What happened?

Selecting alpha faces is running wrong when your image resolution ratio is not 1:1. When I am using selecting alpha in 64x64 or 16x16 images it works well. But in some cases such as 15x16 or 60x64 images, it doesn't work correctly.

What steps are needed to produce the bug?

To use selecting alpha in 15x16 or 60x64 images, doesn't work correctly.

What version of MCprep are you using?

MCprep 3.4.1

What version of Blender are you using?

Blender 3.4

kken498 avatar Feb 26 '23 15:02 kken498

Can you show a screenshot of the console?

StandingPadAnimations avatar Mar 03 '23 02:03 StandingPadAnimations

image image You can see the first image. The alpha faces selection is broken. But it works well in 16x16 images.

kken498 avatar Mar 03 '23 08:03 kken498

Following up on this, I think we should work on a new route to detect alpha faces. The existing algorithm just approximates, so it's not perfect, but I think it can be made better

StandingPadAnimations avatar Dec 21 '23 02:12 StandingPadAnimations

I'm marking this as a bug since it's a regression in the algorithm we use

StandingPadAnimations avatar Dec 21 '23 02:12 StandingPadAnimations