shieldbow icon indicating copy to clipboard operation
shieldbow copied to clipboard

Rewrite/v3

Open TheDrone7 opened this issue 2 years ago • 2 comments

A full rewrite of the main library using the new separated packages.

Progress tracking

  • [x] Client

DDragon (add support for storage)

  • [x] Champions
  • [x] Items
  • [x] Runes
  • [x] Summoner Spells
  • [ ] Arena Augments
  • [x] ~~Challenges~~

API (full rewrite)

  • [x] Account
  • [x] Champion-Mastery
  • [x] Champion
  • [x] Clash
  • [x] League
  • [x] Challenges
  • [x] Status
  • [ ] Match
  • [x] Spectator
  • [x] Summoner
  • [ ] T-stub
  • [ ] Tournament

More features

  • [x] Complex caching (conditional by function per object)
  • [x] Improved storage (verification system)

TheDrone7 avatar Jan 03 '24 06:01 TheDrone7

🦋 Changeset detected

Latest commit: e2982bafef8fe214ecc9899e4529d387ba98c94a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
shieldbow Minor
@shieldbow/web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jan 03 '24 06:01 changeset-bot[bot]

Codecov Report

Attention: Patch coverage is 73.37901% with 1088 lines in your changes missing coverage. Please review.

Project coverage is 83.41%. Comparing base (e232940) to head (6e11c87).

:exclamation: Current head 6e11c87 differs from pull request most recent head e2982ba

Please upload reports for the commit e2982ba to get more accurate results.

Files Patch % Lines
.../shieldbow/src/structures/spectator/participant.ts 24.10% 148 Missing :warning:
packages/shieldbow/src/structures/league/entry.ts 14.38% 125 Missing :warning:
packages/shieldbow/src/structures/league/item.ts 23.80% 96 Missing :warning:
packages/shieldbow/src/structures/summoner.ts 28.70% 77 Missing :warning:
packages/shieldbow/src/structures/mastery.ts 27.27% 72 Missing :warning:
packages/shieldbow/src/managers/api/account.ts 68.48% 51 Missing and 1 partial :warning:
packages/shieldbow/src/managers/api/challenge.ts 86.68% 46 Missing and 5 partials :warning:
...ges/shieldbow/src/structures/spectator/featured.ts 38.27% 50 Missing :warning:
packages/shieldbow/src/structures/league/list.ts 26.98% 46 Missing :warning:
...ckages/shieldbow/src/structures/spectator/runes.ts 30.15% 44 Missing :warning:
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   93.27%   83.41%   -9.87%     
==========================================
  Files          62      112      +50     
  Lines        4684     9102    +4418     
  Branches      563     1142     +579     
==========================================
+ Hits         4369     7592    +3223     
- Misses        302     1468    +1166     
- Partials       13       42      +29     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 03 '24 06:01 codecov[bot]