Expose `pub(crate) fn new` constructors for value types

Open corbanvilla opened this issue 2 years ago • 1 comments

Description

Exposing these constructors is helpful when working with LLVM code which isn't yet part of the C-API.

Dec 28 '23 00:12 corbanvilla

@corbanvilla The newly pub fns need doc comments. Also, Value::new should not be pub since it is internal. Once those are fixed we can merged this

Jan 10 '24 21:01 TheDan64

@TheDan64 apologies for the delay, just added doc comments!

Feb 10 '24 10:02 corbanvilla

@corbanvilla there appear to be some merge conflicts that need to be resolved

Feb 10 '24 22:02 TheDan64

@TheDan64 Could you clarify where you're referring to.... it looks up to date under the files changed tab.

Feb 12 '24 09:02 corbanvilla

For some reason I see

Feb 12 '24 14:02 TheDan64

ah okay it looks like I can do a regular merge instead of a rebase...

Feb 12 '24 14:02 TheDan64